search

ngnrsaa / qflex

Flexible Quantum Circuit Simulator (qFlex) implements an efficient tensor network, CPU-based simulator of large quantum circuits.
Apache License 2.0
97 stars 24 forks source link

Remove qflex-base@docker. #215

Closed s-mandra closed 4 years ago

s-mandra commented 4 years ago

Fixes #214. To have automatic docker images, I need to remove the initial qflex-base@docker.

@alankao64: can you check that everything works? Thanks!

95-martin-orion commented 4 years ago

Fixes #214. To have automatic docker images, I need to remove the initial qflex-base@docker.

What is the plan for automating this? I assume there's an external tool, but I didn't see anything on the issue description.

s-mandra commented 4 years ago

Fixes #214. To have automatic docker images, I need to remove the initial qflex-base@docker.

What is the plan for automating this? I assume there's an external tool, but I didn't see anything on the issue description.

I've created a special user in github that automatically update a fork of our repo. At that point, docker has its own automated tools to keep the docker container updated.

s-mandra commented 4 years ago

Also, I'm creating a new docker user called ngnrsaa so that all the relevant images for this repo are under ngnrsaa/qflex, ngnrsaa/cirq-alpine, ...

s-mandra commented 4 years ago

Ready to go!

95-martin-orion commented 4 years ago

I've tried it at both master and this branch, and I'm seeing the failures below.

For context, make run-tests still works correctly for me.

s-mandra commented 4 years ago

I've tried it at both master and this branch, and I'm seeing the failures below.

For context, make run-tests still works correctly for me.

Everything works for me (both qflex-cxx-tests and qflex-py-tests). Did you clean-up any previous image? That could be an issue that also Alan has found as well. Just to clarify, I've tried:

$ docker-compose build
$ docker run -ti --rm qflex-cxx-tests
$ docker run -ti --rm qflex-py-tests
95-martin-orion commented 4 years ago

Did you clean-up any previous image?

For the previous tests I had deleted all previous docker containers/images, but I guess there was some cached information that the supposedly-fresh images were making use of.

Deleted and re-cloned git repo and all tests passed.