search

ngnrsaa / qflex

Flexible Quantum Circuit Simulator (qFlex) implements an efficient tensor network, CPU-based simulator of large quantum circuits.
Apache License 2.0
97 stars 24 forks source link

Jupyter notebooks with numerical experiments. #234

Open s-mandra opened 4 years ago

s-mandra commented 4 years ago

TODO:

alexandrupaler commented 4 years ago

@s-mandra I have seen that you changed cirq version. Did you encounter bugs with version 0.7?

s-mandra commented 4 years ago

@s-mandra I have seen that you changed cirq version. Did you encounter bugs with version 0.7?

Yes, I get weird errors from cirq. However, if I use #249 the error doesn't appear anymore. So I'm already merging that branch on this PR to avoid the use of cirq==0.6.0.

alexandrupaler commented 4 years ago

@s-mandra: I see. The major change between 0.6 and 0.7 was the removal of Schedules. This has not been adapted in the master branch. The pypi packaging adapted the tests to not include references to Schedules. I guess that is why it is working when you use the pypi branch.

s-mandra commented 4 years ago

@s-mandra: I see. The major change between 0.6 and 0.7 was the removal of Schedules. This has not been adapted in the master branch. The pypi packaging adapted the tests to not include references to Schedules. I guess that is why it is working when you use the pypi branch.

Yes, it gives errors regarding Schedules. We should merge #249 to master asap to avoid any problems.

s-mandra commented 4 years ago

@s-mandra: I see. The major change between 0.6 and 0.7 was the removal of Schedules. This has not been adapted in the master branch. The pypi packaging adapted the tests to not include references to Schedules. I guess that is why it is working when you use the pypi branch.

Yes, it gives errors regarding Schedules. We should merge #249 to master asap to avoid any problems.

For now, I'm fixing this by specifying cirq=0.6 on master.

alexandrupaler commented 4 years ago

the requirements.txt on master should already have 0.6

În dum., 1 mar. 2020 la 12:12, Salvatore Mandra notifications@github.com a scris:

@s-mandra https://github.com/s-mandra: I see. The major change between 0.6 and 0.7 was the removal of Schedules. This has not been adapted in the master branch. The pypi packaging adapted the tests to not include references to Schedules. I guess that is why it is working when you use the pypi branch.

Yes, it gives errors regarding Schedules. We should merge #249 https://github.com/ngnrsaa/qflex/pull/249 to master asap to avoid any problems.

For now, I'm fixing this by specifying cirq=0.6 on master.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ngnrsaa/qflex/pull/234?email_source=notifications&email_token=AEHWGFOUDZ6ZR2QLVZRYB4LRFK6RZA5CNFSM4JM6OD2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENNJO2I#issuecomment-593139561, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEHWGFPV2SEJHVO4UQKUWQTRFK6RZANCNFSM4JM6OD2A .

s-mandra commented 4 years ago

the requirements.txt on master should already have 0.6 În dum., 1 mar. 2020 la 12:12, Salvatore Mandra notifications@github.com a scris: … @s-mandra https://github.com/s-mandra: I see. The major change between 0.6 and 0.7 was the removal of Schedules. This has not been adapted in the master branch. The pypi packaging adapted the tests to not include references to Schedules. I guess that is why it is working when you use the pypi branch. Yes, it gives errors regarding Schedules. We should merge #249 <#249> to master asap to avoid any problems. For now, I'm fixing this by specifying cirq=0.6 on master. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#234?email_source=notifications&email_token=AEHWGFOUDZ6ZR2QLVZRYB4LRFK6RZA5CNFSM4JM6OD2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENNJO2I#issuecomment-593139561>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEHWGFPV2SEJHVO4UQKUWQTRFK6RZANCNFSM4JM6OD2A .

Do we have to change the requirements to cirq=0.7 once #249 is merged to master?

alexandrupaler commented 4 years ago

The change in requirements.txt is taken care of in the PR