search

ngnrsaa / qflex

Flexible Quantum Circuit Simulator (qFlex) implements an efficient tensor network, CPU-based simulator of large quantum circuits.
Apache License 2.0
97 stars 24 forks source link

temporary files do not leak #290

Closed alexandrupaler closed 4 years ago

alexandrupaler commented 4 years ago

Applies the patch from #289 Solves #132 #174 Thank you @kkissell

alexandrupaler commented 4 years ago

@95-martin-orion Is CI disabled on the PRs?

95-martin-orion commented 4 years ago

@95-martin-orion Is CI disabled on the PRs?

It shouldn't be...I wonder why this didn't run them? Just to be safe, I'll change my review status to "Request changes" until this is sorted out.

95-martin-orion commented 4 years ago

@alexandrupaler, it looks like the Travis check failed but for some reason did not report this to the PR. I'll open a separate issue for preventing this kind of test-silence in the future.

For now, I'd recommend fixing the issues logged in the above link (looks like a build failure in Docker run and a separate YAPF complaint) and checking the Travis build list if it still doesn't show up on the PR.

alexandrupaler commented 4 years ago

It was a formatting issue. Solved it and Travis does not complain https://travis-ci.org/github/ngnrsaa/qflex/builds/674505974

alexandrupaler commented 4 years ago

However, irrespective of this PR, we will need to update tests because Cirq 0.8 will obsolete some calls.

alexandrupaler commented 4 years ago

Should I merge this pull request?

95-martin-orion commented 4 years ago

Should I merge this pull request?

I'd double-check the Travis run first, but if it's passing it's fine to merge.