ngnrsaa / qflex

Flexible Quantum Circuit Simulator (qFlex) implements an efficient tensor network, CPU-based simulator of large quantum circuits.
Apache License 2.0
97 stars 24 forks source link

Silent build failures in Travis CI #291

Open 95-martin-orion opened 4 years ago

95-martin-orion commented 4 years ago

As seen on this build from PR #290, it appears that Travis will silently fail if the docker run command fails to build qFlex. Silent failures can potentially allow broken code to be submitted, so we need to fix this ASAP. Possible fixes:

Until this is resolved, please verify that all PRs show Travis checks as complete prior to submitting. Note that due to this bug, the "merge" button might be green without passing Travis checks! Please be careful.

95-martin-orion commented 4 years ago

Further discussion on #290 shows that even successful Travis runs do not show up.

@s-mandra, did we disable the Travis checks? I don't have access to the repo settings, but it should be in there (see this page for how to find it).

s-mandra commented 4 years ago

Let me take a closer look. Thanks for catching this!