coderschoolreview
commented
8 years ago :+1: nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. You learnt how to use AutoLayout to build adaptive UI's that work across many different screen sizes and orientations. If you haven't already, we recommend going back and running your homework again while rotating the device / simulator to ensure your AutoLayout constraints function as expected.
This was a challenging assignment, congrats on completing it successfully!
Grading Summary:
- Functionality: Good
- Code Style: Excellent
- Visual Design: Good
- Usability: Good
Overall: Good
Detailed Notes
- Nice work specifying the Auto Layout constraints.
- Nice work linking the filter model with the controls. See this popular form library for an alternative to implementing forms manually.
- Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.
- Nice job implementing the map.
- When no result found, you should somehow tell the user.
- Infinite loading is interesting, when you need to research and understand the Yelp API. You should consider going back and implementing these improvements as well.
- Your search bar is not in the navigation bar. The purpose of putting the search bar there so that it's always visible. And you misunderstand the search bar function. You need search from the network and update the tableView, not search from what you have in the tableView.
- The distance should not be chosen more than 1 option
- You didn't remember the filter. Every time you go back to FilterVC, you reset everything, which is not a good practice. User may want to see what they did select and modify previous filter setting. Think of how you will implement this.
ngoccuong11789
Hi, this is the submission /cc @coderschoolreview