1st assignment in Swift Class Nov '15 - Jade

[ngocle511]

I have completed my project. Please check and send feedback to help me improve. Thanks a lot! /cc @coderschoolreview

[coderschoolreview]

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Average
• Code Style: Excellent
• Visual Design: Average
• Usability: Good
• Overall: Good

Detailed Notes

YES

• Your code is pretty clean. The only thing is that you often don't need self. For more information read up on the style guide:
  • Ray Wenderlich Swift Style Guide
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response. For a more robust solution, you can also investigate using an ORM like Pistachio.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Your images are loading synchronously. This will block the UI thread and make it so that your app appears frozen while the images are being downloaded. This is why scrolling the table view is not smooth. Please do not use contentsOfURL, but instead use the setImageForURL on the imageView.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Nice work implementing the error message on network failure, but you should set self.viewError.hidden = true if it succeeds the next time.
• Consider a solution that allows a user to see the entire movie synopsis in the Movie Detail View. Right now it is being truncated. Allowing scrolling by adding a UIScrollView would fix that.

• Keep alignment in mind when designing a mobile app. Alignment makes a design more neat and organized so that it's easier to read or use. This means that readers will find what they want without frustration For more information about grid theory, you can read the article here.

  To use alignment properly, imagine there are evenly-spaced vertical lines running through the entire length of the design. Both the left and right edges of every single item should fall along these lines, which designers call a grid.

  You want to align as many items as possible along the same grid lines. Instead of looking at layout like the game Tetris, where the goal is to fill every available space, try to arrange elements in neat columns.

Homework is the core part of this class. Through the homework assignments you'll create real apps that you should be proud to show anybody. The more time you spend, the better your portfolio will be and the more you will learn. Try to spend a little more time next week! You almost got the tab bar working. :cow:

[ngocle511]

Hi Coderschool team! Many thanks for your detailed review. I will try your instruction to improve my app. Have a great class ;)