Assignment #2 : YELP - Jade

[ngocle511]

Here is my completed project. Please check! Thanks /cc @coderschoolreview

[coderschoolreview]

:+1: nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.

This was a challenging assignment, congrats on completing it successfully!

Thanks for the early submission, but you do have a few bugs. There's one quick bug - sometimes the imageURL is nil, so you should be able to handle this instead of crashing.

I also could not get search to work, just from the Search Bar.

Last but not least, for Swift Coding Convention:

if let imageUrlString = dictionary["image_url"] {
            imageURL = NSURL(string: imageURLString!)!
} else {
            imageURL = nil
}        

is generally nicer than doing if foo == nil.

Nice work specifying the Auto Layout constraints. Fix your warnings, no big deal:

• Nice work linking the filter model with the controls. See this popular form library for an alternative to implementing forms manually.
• Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.

Looks great. You seem to be learning a lot! Isn't it nice to have a separate model in Business.swift than doing all the logic in the ViewController? :tophat:

[ngocle511]

Hi Coderschool Team,

Thank you for your great review. I have to work harder to improve the code in the other projects.

Ngoc Le

On Nov 26, 2015, at 3:18 PM, coderschoolreview notifications@github.com wrote:

nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.

This was a challenging assignment, congrats on completing it successfully!

Thanks for the early submission, but you do have a few bugs. There's one quick bug - sometimes the imageURL is nil, so you should be able to handle this instead of crashing.

I also could not get search to work, just from the Search Bar.

Last but not least, for Swift Coding Convention:

if let imageUrlString = dictionary["image_url"] { imageURL = NSURL(string: imageURLString!)! } else { imageURL = nil }
is generally nicer than doing if foo == nil.

Nice work specifying the Auto Layout constraints. Fix your warnings, no big deal:

Nice work linking the filter model with the controls. See this popular form library for an alternative to implementing forms manually.

Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.

Looks great. You seem to be learning a lot! Really enjoy that you made a separate model class in Business.swift.

— Reply to this email directly or view it on GitHub.