search

ngoctuan / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Update MyFilmsLogos.xml default logo definition file to match MP13 naming conventions #168

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Update MyFilmsLogos.xml default logo definition file to match MP13 naming 
conventions

Original issue reported on code.google.com by Guzz...@googlemail.com on 17 Aug 2012 at 2:35

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2387.

Original comment by Mikeplan...@web.de on 17 Aug 2012 at 2:38

GoogleCodeExporter commented 9 years ago 
Is there only one logos rules xml for both 1.2.x and 1.3.0?  Now that the rules 
match the logos for 1.3.0 several logos no longer match in 1.2.x. Or perhaps 
there is some other bug because in Logos setup, many logos are missing an Image 
path, even though the logos exist - applies to both "Use skin logos" when 
default skin is selected, as well as 'Use MF Logos' and 'Use MP Logos" (see 
attached screenshots)

Subtitles logo now displays for all films in 1.2.x (I am guessing the filed is

Several logo images files were added or renamed in 
MyFilms\Installer\Thumbs\MyFilms\DefaultLogos.MP13 however they do not match 
the logos style in \MyFilms\Installer\Thumbs\MyFilms\DefaultLogos so we cannot 
simply copy the new images to the DefaultLogos folder so they would match the 
new rules.

Original comment by Dade...@gmail.com on 25 Aug 2012 at 8:31

Attachments:

GoogleCodeExporter commented 9 years ago 
Ok my bad about subtitles logo - in Default skin (1.2.x) you can hardly tell 
the diff between the no subtitles and subtitles logos!

But the other issues still apply. 

Also, do you plan to add a cinemascope.png logo to MF logos pack to match the 
new rule?  Otherwise I think aspectratio logos will not display for many movies 
which contain '2.'

Original comment by Dade...@gmail.com on 25 Aug 2012 at 10:32

GoogleCodeExporter commented 9 years ago 
I created and tested the logo rules against the logos delivered with MP1.3. The 
missing logos were added to the installer.
Yes, I am aware, that we do not have all of them neither in MP1.2 nor in the 
extra logo pack.
So since we don't have any logo creators (I could do it, if you have the source 
files of MP13 logos), we might deliver specific logo rule - probably easiest 
would be to deliver a MyFilmsLogo.xml with the default skins - so the generic 
one applies to all MP1.3 and other skins. 
Cinemascope.png added.

Original comment by Guzz...@googlemail.com on 27 Aug 2012 at 11:19

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2491.

Original comment by Dade...@gmail.com on 2 Sep 2012 at 6:58

GoogleCodeExporter commented 9 years ago 
Related to   Issue #169 : Genre logos do not display correctly in MP 1.3.x + 
missing logos/genre images

Docs updated there (so changed this issue to Docs-NotReq

Original comment by Dade...@gmail.com on 8 Sep 2012 at 12:19

GoogleCodeExporter commented 9 years ago 
Have matched all existing logos in MP 1.2.x to logo rules now. As reported in 
Issue #169 there are a few odd genre ones missing for 1.2.x but those are not 
essential.

As agreed - for now we use SD logo for most non-HD resolutions.

Original comment by Dade...@gmail.com on 16 Sep 2012 at 11:35