search

ngoctuan / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Enable person list for movies in "normal" mode #76

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Context menu for a movie allows to show the persons of the current movie.
New "Persons" field, that is created by the content of the initial person 
related fields (like Actors, Producer, Writer, etc.) allows to show all persons 
related to that movie.
To allow better testing, this feature should be enabled in "normal" mode.

Original issue reported on code.google.com by Mikeplan...@web.de on 21 Dec 2011 at 1:14

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r1810.

Original comment by Mikeplan...@web.de on 21 Dec 2011 at 1:20

GoogleCodeExporter commented 9 years ago 
This allows to show all ("Persons") or specific persons ("Actors", "Producer", 
etc.) involved in that movie and present them in a "view", that will show 
number of movies available for the respective person. Available movies get be 
selected in facade navigation.
Context menu will show "person related entries" - so this will allow e.g. 
updates for person info via context menu in the future, showing IMDB internet 
info etc.

Original comment by Mikeplan...@web.de on 21 Dec 2011 at 1:22

GoogleCodeExporter commented 9 years ago 
OK I assume you mean the main window context menu option "Info for related 
person" - should probably be 'person(s)' now that it is normally plural.

I have issues in build 1818 with the navigation > back/esc in Persons view.
1. Select 'Info for related person' from Context Menu
2. Select an option, such as actors
3. Go to Persons view - nicely displays the persons and counts of movies in 
which they appear as an actor :)
4. Press Back/Esc - if I do not displayed the film list for that person, it 
does nothing the first click.  Then press back/esc again and you go to the full 
Persons list, not back to the Main list where you came from. That also makes 
the navigation very slow as it tries to display list for all persons (~12K for 
me)

If I display the film list from Persons View, then press Esc/Back, I do not get 
the issue where it does nothing, however it still goes 'back' to full Persons 
Selection.

I also get some exceptions in MyFilms.log when trying to load person details. 
So I attached it in case they reveal an issue.

Original comment by Dade...@gmail.com on 26 Dec 2011 at 4:48

Attachments:

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r1832.

Original comment by Mikeplan...@web.de on 29 Dec 2011 at 6:25

GoogleCodeExporter commented 9 years ago 
It is intended, that after restricted person list, going back goes to full 
person list - similar to filtered film lists going back to full film list.

Original comment by Mikeplan...@web.de on 29 Dec 2011 at 6:28

GoogleCodeExporter commented 9 years ago 
Well going back to film list from filtered lists makes sense since you entered 
from there. You are not going 'back' to full person list in this case because 
you were never there ;) 

More importantly, films lists do not take nearly as long to load as full person 
list.  It is just too slow/awkward to always return to full persons list.

Original comment by Dade...@gmail.com on 29 Dec 2011 at 6:36

GoogleCodeExporter commented 9 years ago 
Updated Using My Films wiki page > Context menu with new screenshots and 'info 
for related person(s)'

Original comment by Dade...@gmail.com on 29 Dec 2011 at 6:58

GoogleCodeExporter commented 9 years ago 
So you'd suggest to go where? Actually, you're not really coming from any view, 
as you're jumping to something new - the involved persons.
I tested with 150 K persons - not too fast, took 5 secs, but imho ok for that 
amount of items... ;-)

Original comment by Mikeplan...@web.de on 29 Dec 2011 at 9:08

GoogleCodeExporter commented 9 years ago 
I suggest to go to the same place as when you press Esc on full person list, 
i.e. just bypass the full person list. I think this will always be the main 
window, since AFAIK you can only access Info for Related Person(s) from the 
main Context Menu. 

To be consistent, if you select a View from the MF Menu, such as Producers, 
when you press Esc/back you return to the Films view/main list, (default start 
view I think) regardless of what view was previously selected. So I think we 
could do the same here?

My point is that this is actually a very nice feature - if you are looking for 
info on persons for the current film it is much faster/better than going to a 
full persons view and finding the related person. However, for me, it loses 
much of it's advantage because it is so awkward to get out of it. The 'bug' 
when you press Esc without accessing the film list (does nothing) still 
persists in build 1837. Normally I would search related films by person for 
film lists. So imo this bug is important because you usually just view the 
persons info and press Esc to go back to the Films list.

For me, it takes about 2 secs (which is acceptable) to open the view for 
related persons, even if you select all persons. BUT it takes MORE than 5 secs 
to display the full persons view when I press Esc/Back even though I have only 
12K persons so far. For me that is not acceptable and would deter me from using 
what is otherwise an excellent feature , especially as it is unnecessary to 
even view the full persons view in this context.

Original comment by Dade...@gmail.com on 30 Dec 2011 at 7:21

GoogleCodeExporter commented 9 years ago 
All this navigation stuff is VERY tricky, as so many different cases are 
possible - like returning from home, jumping into MF from other plugin, etc. - 
all this has to work properly on top of the "normal navigation".
We could have created a separate skin page for persons - that might have made 
things better separated from "films views" - but I tried to avoid that so we 
don't need another skinfile. However, it complicates the internals, as it all 
has to work on the same facade...
ok, so basically it is two things to be done:
- Fix navigation when immideately returning from person list view
- skip full person list
Should we reopen this issue or create new ones?

Original comment by Mikeplan...@web.de on 30 Dec 2011 at 10:14

GoogleCodeExporter commented 9 years ago 
I think it is ok to fix those two things in this issue, no need for new ones :)

IF you really think a separate window for Persons would help, especially 
improve performance, then we can add an issue for that! Damien never hesitates 
;) Trakt has 23 skin files! It's about the same amount of xml code and 
sometimes it is easier to skin when things are separated. BUT I would only do 
it if there is some benefit to you for future development OR to users 
(performance).

Original comment by Dade...@gmail.com on 30 Dec 2011 at 11:05

GoogleCodeExporter commented 9 years ago 
Added a ReOpened tag so we can use it - hopefully not too often :)

Original comment by Dade...@gmail.com on 30 Dec 2011 at 11:07

GoogleCodeExporter commented 9 years ago 
Due to rework of the MyFilms core for views and navigation, we'll have to 
recheck and probably refix those issues - I tried to cleanup basic navigation 
so far, so as soon as this is tested and confirmed working, we can/must test 
how to navigate from "special views" like context person lists, search results, 
etc.

Original comment by Mikeplan...@web.de on 15 Jan 2012 at 3:29

GoogleCodeExporter commented 9 years ago

Original comment by Guzz...@googlemail.com on 13 Jun 2012 at 8:01

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2312.

Original comment by Mikeplan...@web.de on 24 Jul 2012 at 11:53

GoogleCodeExporter commented 9 years ago 
introduce separate GUI properties for person info:
#myfilms.person.name.value
#myfilms.person.biography.value
#myfilms.person.dateofbirth.value
#myfilms.person.placeofbirth.value
Not available with MP1.2, with MP1.3 there will be supported:
#myfilms.person.dateofdeath.value
#myfilms.person.placeofdeath.value
#myfilms.person.lastupdate.value
This allows skinner to bee free for placement (info was loaded in movie 
properties before ....)

Original comment by Guzz...@googlemail.com on 27 Jul 2012 at 2:23

GoogleCodeExporter commented 9 years ago 
I can see the properties in Default Wide (persons views), but not in Default 
4x3 yet right?

How do you populate the data for those fields? Context menu only includes an 
option to display web pages. Let me guess - you have to select Enable Downloads 
on artwork tab to get perons data as well.  Sorry but that is not very obvious 
or intuitive! ;)

Does the option on Details Context menu to download person images now download 
person info for all persons as well? (doesn't do it when I tried it)

When in any persons view you should have an option to download persons info - 
including one image, (that was what we had originally decided)

Original comment by Dade...@gmail.com on 2 Aug 2012 at 4:56

GoogleCodeExporter commented 9 years ago 
Ok I figured out you can use the Info for related persons option to grab data 
But I have to say it is all very confusing:
1. You can download persons images from Details Screen or Enable auto download 
of images in Artwork Setup
2. To actually grab persons info, you use the Main Screen > Info for related 
persons
3. You can view persons info in persons views, via IMDB web pages, but you 
cannot download any info or images from there.

Still not sure if/how you can grab person info when importing or using Get 
Internet Info in GUI.

Original comment by Dade...@gmail.com on 2 Aug 2012 at 6:47

GoogleCodeExporter commented 9 years ago 
Re skins: only added it for DefaultWIde, yes. It is showing same as befoere 
(when we populated the movie items with person data .... which was imho also 
confusing, no?
Re population: When you're in a person view, MyFilms will try to get that info 
from MyVideo Actor DB. (it is like that since > 1 year already).
THe DB itself can be populated via MP setup or later (MP1.3) automatically or 
from GUI. In MyFilms, it will be populated in the related persons view - so you 
are not deüpendant on MP populating the DB, e.g. because you are not using 
myvideos at all.
We discussed separate MyFilms person DB, but that fur sure won't happen for 6.0.
Re downloader in details: No, it only loads images (as we needed those for the 
details skin...). Please add issue, if that shoud happe (I think it is a good 
idea, as it is less intrusive and disturbing there ....)
Re manual download option: There is a person download option, but it is only 
available in test mode and it is nopt yet working proerly. It is script based, 
thus allowing loading data from different websites (in theory). BUT: I don't 
want to finish/fix that part, until we dicided, where and what info about 
persons will go.
Imho, the current "automatic" loading is not too bad - it gives users with 
little effort data for their persons ... and I doubt, users want to download 
person info name by name manually (I have test DB with 200.000 persons here ... 
it would take me ages to update them manually ;-)
Re "internetinfo": True, that does NOT include person info - as that is a 
separate grabber process. It is currently NOT included in AMCupdater also, as 
there is no person DB.

Conclusion:
Two possible addons:
- extend backgroundworker in details to include person details
- fix and enable manual person download, using grabber engine (instead of 
inbuild IMDB/TMDB API).
the latter I don't want to do for 6.0, extension of details loader is imho 
possbile.

PLADV.

Original comment by Guzz...@googlemail.com on 2 Aug 2012 at 11:49

GoogleCodeExporter commented 9 years ago 
I do not think we should extend the background worker in Details screen for 
6.0.0. I think we need to integrate AMCU/Import and ensure there is some 
logic/consistency with other import/update options. 

If you Enable Downloads for persons Views then select Info for related persons 
from the Main context menu, it does use the background process and works 
nicely!  However, if you do not Enable downloads for persons views on artwork 
tab, then there is no way to download persons info (only images via the new 
Download Person Images via Details context menu)

Original comment by Dade...@gmail.com on 10 Aug 2012 at 9:55

GoogleCodeExporter commented 9 years ago 
Re extending AMCupdater/importer for person info:
I am not convinced. Actually, we would implement methods in AMCU to populate 
the MyVideoDBs actor tables! - that is already there in MP setup. I used it in 
the past already to get actor infos. It is of course not htat userfriendly, and 
the current implementation is nicer, as the user doesn't need to do anything by 
himself.
I DO agree, that in general it belongs there - but we don't have a people DB 
where we can store it currently, as I mentioned above.
It is correct, that you do not get person info, if you disable the autop person 
downloads - but hey, that's life - if you disable something you don't get it :-)

Most inportant question is, if we enable the auto doanloads by default or not. 
All other to be decided post V6 imho.

Original comment by Guzz...@googlemail.com on 10 Aug 2012 at 5:24

GoogleCodeExporter commented 9 years ago

Original comment by Dade...@gmail.com on 27 Sep 2012 at 6:11