Closed diepquynh closed 8 years ago
Confirmed.
Now is this most annoying issue
I guess CM13 developer options are broken
Or our HALs are broken :)
I guess again, gralloc's fault
May be this commit will fix this issue https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/commit/5b47381b39bf9be47ede313f7539004c5028b272.
So, do we need to revert this? https://github.com/koquantam/android_frameworks_base/commit/1003c499017267bc497fc45cf8802cb933d9781b
This Gerrit review http://review.cyanogenmod.org/#/c/125226/ is abandoned so we should not revert your mentioned commit. I just gave a ref from the i9300 device which has the same issue as us.
I hasn't had any flickering since that change so I will close this issue.
Oh well, I would test so
OK
2016-07-07 10:17 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:
But if I had, you have to open it again :D
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230968727, or mute the thread https://github.com/notifications/unsubscribe/AJOl9v8ncB9LzwdEgw-fqmPFhpYHYpvkks5qTG_cgaJpZM4I1n3i .
Anyway, do you plan making Nougat for our phone?
I will wait until we have its source codes :)
2016-07-07 10:21 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:
Anyway, do you plan making Nougat for our phone?
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230969111, or mute the thread https://github.com/notifications/unsubscribe/AJOl9s6tef3tKzsvPJPi30K7NVFU9tAjks5qTHC-gaJpZM4I1n3i .
Yes, I'll wait too :D Our country needs people like you
Confirmed
It's very nice that we don't face black preview recents like CM12.1 in CM13 anymore And once again, one BoardConfig flag solves the problem o.O
Codecs work great in CM13 with minor modification :)
2016-07-07 10:59 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:
It's very nice that we don't face black preview recents like CM12.1 in CM13 anymore
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230973496, or mute the thread https://github.com/notifications/unsubscribe/AJOl9uV_X-VklezPanLAejJL8znEiCVWks5qTHmtgaJpZM4I1n3i .
Actually, stock gralloc also does that change :v
You mean the fix for ScreenRecording? I haven't found the root cause of that issue yet.
2016-07-07 11:10 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:
Actually, stock gralloc also does that change :v
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230974612, or mute the thread https://github.com/notifications/unsubscribe/AJOl9oU4YVxHZhDktWiVDq0xc4dxVS1Eks5qTHwvgaJpZM4I1n3i .
Yes, screen recording
But that was fixed https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/commit/67ad84476b4044701a869c51582ae744bdd0fab2
2016-07-07 11:20 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:
Yes, screen recording
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230975544, or mute the thread https://github.com/notifications/unsubscribe/AJOl9mmF4wBx9zFNetDbaSJFMyZmzXA0ks5qTH6BgaJpZM4I1n3i .
These HALs you took from sp7715ga_gonk4.4_hemiao_mp
branch right?
So this is why it doesn't work with me
Yes. Your board is sc8830, right?
2016-07-07 11:25 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:
These HALs you took from sp7715ga_gonk4.4_hemiao_mp branch right? So this is why it doesn't work with me
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230976046, or mute the thread https://github.com/notifications/unsubscribe/AJOl9i8d7SlYiYMlv4sU7c2pJgMdUUliks5qTH-ygaJpZM4I1n3i .
Yes. The sprdroid4.4
branch works for me, except gralloc
It gives me an error, like deleted function
which I never faced before
Give me the compile error log, I could help if I can.
2016-07-07 11:29 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:
Yes. The sprdroid4.4 branch works for me, except gralloc It gives me an error, like deleted function which I never faced before
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230976455, or mute the thread https://github.com/notifications/unsubscribe/AJOl9gDWba02u7hbEL3o2LP86-IOFrlIks5qTICzgaJpZM4I1n3i .
Here
I know that bug, compare my gralloc framebuffer_device.cpp, you will see the differences.
2016-07-07 11:41 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:
Here [image: screenshot from 2016-07-07 11 40 36] https://cloud.githubusercontent.com/assets/13411810/16642703/aaffa0d8-4437-11e6-9d93-7b7d063394ca.png
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230977644, or mute the thread https://github.com/notifications/unsubscribe/AJOl9hbyni24xOE-Qtdn9irvkiod-IOKks5qTINggaJpZM4I1n3i .
Thanks bro. Now its usable
Bro, I think we should switch all libs changes to vendor tree Now we don't have same device anymore, but at least our devices has same SoC types that we can easily sync our changes on
OK, I will plan it.
But don't use my android_vendor_sprd_open-source
tree. I just use it to view the history.
We should make android_hardware_samsung_sprd-common
tree instead.
Oh, you're right But I've just pushed a commit on vendor tree for an hour :D
I planed to fork @TeamButter sprd-common
tree, but there are too many conflicts so I afraid of doing that :)
Well most of their tree are for sc8810, while ours are scx15 and sc8830 But anyway, can we make separated folder for each SoC?
Yes. And another tree android_device_samsung_sprd-common
.
Bro, I remember you've fixed wrong color with camera using H264 AVC codec Can you locate me to that commit?
2016-07-07 22:22 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:
Bro, I remember you've fixed wrong color with camera using H264 AVC codec Can you locate me to that commit?
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-231111704, or mute the thread https://github.com/notifications/unsubscribe/AJOl9q69MAvkkTZk0cbwsZWDI0BI3DvYks5qTRnTgaJpZM4I1n3i .
I've made a common hardware tree. Can you check it out and try using it?
Sometimes the phone does that, but with the affected apps only, even with disabled "Strict mode". Quick solution is tapping on recents button, then come back with the current opening app