ngoquang2708 / android_device_samsung_vivalto3gvn

Device tree for Samsung Galaxy V SM-G313HZ
7 stars 8 forks source link

cm-13.0: Screen flickering #46

Closed diepquynh closed 8 years ago

diepquynh commented 8 years ago

Sometimes the phone does that, but with the affected apps only, even with disabled "Strict mode". Quick solution is tapping on recents button, then come back with the current opening app

ngoquang2708 commented 8 years ago

Confirmed.

diepquynh commented 8 years ago

Now is this most annoying issue

diepquynh commented 8 years ago

I guess CM13 developer options are broken

ngoquang2708 commented 8 years ago

Or our HALs are broken :)

diepquynh commented 8 years ago

I guess again, gralloc's fault

ngoquang2708 commented 8 years ago

May be this commit will fix this issue https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/commit/5b47381b39bf9be47ede313f7539004c5028b272.

diepquynh commented 8 years ago

So, do we need to revert this? https://github.com/koquantam/android_frameworks_base/commit/1003c499017267bc497fc45cf8802cb933d9781b

ngoquang2708 commented 8 years ago

This Gerrit review http://review.cyanogenmod.org/#/c/125226/ is abandoned so we should not revert your mentioned commit. I just gave a ref from the i9300 device which has the same issue as us.

ngoquang2708 commented 8 years ago

I hasn't had any flickering since that change so I will close this issue.

diepquynh commented 8 years ago

Oh well, I would test so

ngoquang2708 commented 8 years ago

OK

2016-07-07 10:17 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:

But if I had, you have to open it again :D

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230968727, or mute the thread https://github.com/notifications/unsubscribe/AJOl9v8ncB9LzwdEgw-fqmPFhpYHYpvkks5qTG_cgaJpZM4I1n3i .

diepquynh commented 8 years ago

Anyway, do you plan making Nougat for our phone?

ngoquang2708 commented 8 years ago

I will wait until we have its source codes :)

2016-07-07 10:21 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:

Anyway, do you plan making Nougat for our phone?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230969111, or mute the thread https://github.com/notifications/unsubscribe/AJOl9s6tef3tKzsvPJPi30K7NVFU9tAjks5qTHC-gaJpZM4I1n3i .

diepquynh commented 8 years ago

Yes, I'll wait too :D Our country needs people like you

diepquynh commented 8 years ago

Confirmed

diepquynh commented 8 years ago

It's very nice that we don't face black preview recents like CM12.1 in CM13 anymore And once again, one BoardConfig flag solves the problem o.O

ngoquang2708 commented 8 years ago

Codecs work great in CM13 with minor modification :)

2016-07-07 10:59 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:

It's very nice that we don't face black preview recents like CM12.1 in CM13 anymore

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230973496, or mute the thread https://github.com/notifications/unsubscribe/AJOl9uV_X-VklezPanLAejJL8znEiCVWks5qTHmtgaJpZM4I1n3i .

diepquynh commented 8 years ago

Actually, stock gralloc also does that change :v

ngoquang2708 commented 8 years ago

You mean the fix for ScreenRecording? I haven't found the root cause of that issue yet.

2016-07-07 11:10 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:

Actually, stock gralloc also does that change :v

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230974612, or mute the thread https://github.com/notifications/unsubscribe/AJOl9oU4YVxHZhDktWiVDq0xc4dxVS1Eks5qTHwvgaJpZM4I1n3i .

diepquynh commented 8 years ago

Yes, screen recording

ngoquang2708 commented 8 years ago

But that was fixed https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/commit/67ad84476b4044701a869c51582ae744bdd0fab2

2016-07-07 11:20 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:

Yes, screen recording

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230975544, or mute the thread https://github.com/notifications/unsubscribe/AJOl9mmF4wBx9zFNetDbaSJFMyZmzXA0ks5qTH6BgaJpZM4I1n3i .

diepquynh commented 8 years ago

These HALs you took from sp7715ga_gonk4.4_hemiao_mp branch right? So this is why it doesn't work with me

ngoquang2708 commented 8 years ago

Yes. Your board is sc8830, right?

2016-07-07 11:25 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:

These HALs you took from sp7715ga_gonk4.4_hemiao_mp branch right? So this is why it doesn't work with me

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230976046, or mute the thread https://github.com/notifications/unsubscribe/AJOl9i8d7SlYiYMlv4sU7c2pJgMdUUliks5qTH-ygaJpZM4I1n3i .

diepquynh commented 8 years ago

Yes. The sprdroid4.4 branch works for me, except gralloc It gives me an error, like deleted function which I never faced before

ngoquang2708 commented 8 years ago

Give me the compile error log, I could help if I can.

2016-07-07 11:29 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:

Yes. The sprdroid4.4 branch works for me, except gralloc It gives me an error, like deleted function which I never faced before

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230976455, or mute the thread https://github.com/notifications/unsubscribe/AJOl9gDWba02u7hbEL3o2LP86-IOFrlIks5qTICzgaJpZM4I1n3i .

diepquynh commented 8 years ago

Here screenshot from 2016-07-07 11 40 36

ngoquang2708 commented 8 years ago

I know that bug, compare my gralloc framebuffer_device.cpp, you will see the differences.

2016-07-07 11:41 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:

Here [image: screenshot from 2016-07-07 11 40 36] https://cloud.githubusercontent.com/assets/13411810/16642703/aaffa0d8-4437-11e6-9d93-7b7d063394ca.png

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-230977644, or mute the thread https://github.com/notifications/unsubscribe/AJOl9hbyni24xOE-Qtdn9irvkiod-IOKks5qTINggaJpZM4I1n3i .

diepquynh commented 8 years ago

Thanks bro. Now its usable

diepquynh commented 8 years ago

Bro, I think we should switch all libs changes to vendor tree Now we don't have same device anymore, but at least our devices has same SoC types that we can easily sync our changes on

ngoquang2708 commented 8 years ago

OK, I will plan it.

ngoquang2708 commented 8 years ago

But don't use my android_vendor_sprd_open-source tree. I just use it to view the history. We should make android_hardware_samsung_sprd-common tree instead.

diepquynh commented 8 years ago

Oh, you're right But I've just pushed a commit on vendor tree for an hour :D

ngoquang2708 commented 8 years ago

I planed to fork @TeamButter sprd-common tree, but there are too many conflicts so I afraid of doing that :)

diepquynh commented 8 years ago

Well most of their tree are for sc8810, while ours are scx15 and sc8830 But anyway, can we make separated folder for each SoC?

ngoquang2708 commented 8 years ago

Yes. And another tree android_device_samsung_sprd-common.

diepquynh commented 8 years ago

Bro, I remember you've fixed wrong color with camera using H264 AVC codec Can you locate me to that commit?

ngoquang2708 commented 8 years ago

https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/commit/245e30afc7fa164b0d1e356c8529c8f8d694b234

2016-07-07 22:22 GMT+07:00 Nguyễn Tuấn Quyền notifications@github.com:

Bro, I remember you've fixed wrong color with camera using H264 AVC codec Can you locate me to that commit?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ngoquang2708/android_device_samsung_vivalto3gvn/issues/46#issuecomment-231111704, or mute the thread https://github.com/notifications/unsubscribe/AJOl9q69MAvkkTZk0cbwsZWDI0BI3DvYks5qTRnTgaJpZM4I1n3i .

diepquynh commented 8 years ago

I've made a common hardware tree. Can you check it out and try using it?