search

ngot / libv8

Convert V8 project from GN build system to CMake build system and build for static lib.
13 stars 6 forks source link

Not copying some required header files #1

Open nicole-mcg opened 5 years ago

nicole-mcg commented 5 years ago

I'm getting this error when running ./build.sh 

file included from /Users/connor/code/libv8/v8/src/zone/accounting-allocator.h:17:
/Users/connor/code/libv8/v8/testing/gtest/include/gtest/gtest_prod.h:10:10: fatal error:
      'third_party/googletest/src/googletest/include/gtest/gtest_prod.h' file
      not found
#include "third_party/googletest/src/googletest/include/gtest/gtest_prod.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /Users/connor/code/libv8/v8/src/address-map.cc:6:
In file included from /Users/connor/code/libv8/v8/src/heap/heap.h:25:
In file included from /Users/connor/code/libv8/v8/src/objects/fixed-array.h:8:
In file included from /Users/connor/code/libv8/v8/src/maybe-handles.h:10:
In file included from /Users/connor/code/libv8/v8/src/handles.h:21:
In file included from /Users/connor/code/libv8/v8/src/zone/zone.h:16:
In file included from /Users/connor/code/libv8/v8/src/zone/accounting-allocator.h:17:
/Users/connor/code/libv8/v8/testing/gtest/include/gtest/gtest_prod.h:10:10: fatal error:
      'third_party/googletest/src/googletest/include/gtest/gtest_prod.h' file
      not found
#include "third_party/googletest/src/googletest/include/gtest/gtest_prod.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I am looking into how to fix this, I'm not sure what the cause of this problem is

ngot commented 5 years ago

Thanks for your notice of my project. I did not pay too much attention to the v8 project recently. It might be some change in v8 that I have not covered. I will investigate it.

nicole-mcg commented 5 years ago

I got it building using CMake on osx here https://stackoverflow.com/questions/53379099/c-v8-embedding-project-structure

ngot commented 5 years ago

@c-mcg Could you provide me with the reproduce steps? I have tried but not error occurred.

nicole-mcg commented 5 years ago

I was getting this error on a mac (Mojave) by cloning your repo and following the Readme instructions

ngot commented 5 years ago

v8 has changed a lot since then. The code inside repo is still compiling, but an upgrade is hard. I don't have enough time to do the upgrade now. If anyone could help me doing this, that will be great.