Review Twitter assignment

[ngothanhtai]

Hi,

I have completed my assignment, please review my code /cc @coderschoolreview

Thanks and cheers, Tai

[coderschoolreview]

:+1: Nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API.

Grading Summary:

• Functionality: Excellent
• Code Style: Average
• Visual Design: Good
• Usability: Excellent
• Overall: Excellent

Detailed Notes

Great things:

• Nice work specifying the Auto Layout constraints.
• Nice work handling the retweet label by dynamically modifying the constraint. This is a situation where its not possible to specify the behavior that you want solely using Interface Builder.
• Nice work setting up the controls within the Tweet cells. It can sometimes be hard to have a clean design for embedded controls because it usually involves cumbersome plumbing. This is an instance where I think having the model handle the network action helps greatly simplify the implementation.
• Nice work handling the post tweet insertion into the feed. In real MVC apps, the more polished experiences have to do a certain amount of local object management to make a fully seamless experience.
• Good job for displaying the username in reply.
• Well done for implementing infinite loading.

Some small comments

• You should show number of replies, retweets and favorites in Home page.
• A reply begins with username, so the countdown should have be initialized at 140 - username.length
• This date format seems too long. The day is duplicated.
• You should display something to distinguish normal tweet and reply tweet.
• TweetComposeViewController and ReplyViewController are look similar. Why do you create 2 view controllers for them?
• You can consider to display in minutes or days with the recent tweets instead of the full date, but this's not a big deal :smile:
• Please notice my comments in your code to improve your code style.

Excellent submission overall :horse_racing: This assignment is pretty hard, congrats on completing it! :star2: It was here to teach you about keeping track of "state" of objects, and also to be the first assignment to accept user input.

[ngothanhtai]

Thank you so much for reviewing through all my code :+1:. I will update and remember to avoid those mistakes next time :blush: