ngovil21 / RequestChannel.bundle

Request Channel - A Plex Channel to create requests
158 stars 22 forks source link

Language files for translations #16

Open Ruvetuve opened 8 years ago

Ruvetuve commented 8 years ago

Nice Channel! Works like a charm. I want to request a language file option. This way i can translate it in my own language. Is this feasible?

ngovil21 commented 8 years ago

Yes that is possible. I will start working on it. Lots of strings to go through.

Ruvetuve commented 8 years ago

Great! I remember for an other plex channel there is a website to start the translation of the strings in a ordered way. I'll try to find it.

ngovil21 commented 8 years ago

I have added the localization to the development branch for now.

You will need to make a copy of the en.json file and name the file with the two letter code for your language. Translate the strings on the right side of the colon (:). If you see a %s, then the %s should stay in the same place in the translation.

If you would like me to add the translation file you make, you can submit a pull request, or just send it to me here.

Hope everything works.

Ruvetuve commented 8 years ago

Wow fast! Let me check and translate

seb972 commented 8 years ago

Hello,

I want to help this greatfull work with a French translation.

Can you say me if i can use accent as é à with the other (UTF-8 ?)

seb972 commented 8 years ago

Hi,

Check my work to translate in french

fr.zip

Ruvetuve commented 8 years ago

Working on Dutch over here :)

ngovil21 commented 8 years ago

@seb972 Thanks for the translation. I have added to the plugin, but in my testing it hasn't worked. Can you confirm on the latest branch if it works for you?

May need to add some fixes for the way Plex handles languages.

Do you know if language localization works in any other channel?

seb972 commented 8 years ago

sorry i don't try languauge localization on other channel. I try the development branch and i give you my feedback.

ngovil21 commented 8 years ago

That's okay, most likely it won't work right now, but I have some fixes in mind.

seb972 commented 8 years ago

how can i make a git clone on development branch?

ngovil21 commented 8 years ago

Are you using the git tool, or are you downloading the .zip file?

If you are using git, go to the folder that has the plugin, type in git checkout development and then git pull.

If you are using the zip files, just wait until I merge into master. It'll be easier that way.

seb972 commented 8 years ago

i use the git tool on linux, i try git clone -b development and it work, but the language not change.

ngovil21 commented 8 years ago

OK that's what I thought. Hang on I'm going to have to figure this out.

seb972 commented 8 years ago

Do you see this?

https://forums.plex.tv/discussion/95377/language-support-client-or-server-based

ngovil21 commented 8 years ago

Yes, I was doing it correctly, but it's a problem with Plex. I found a fix that someone posted and it works. Please update the development branch and try it again.

Ruvetuve commented 8 years ago

Dunno how to submit Dutch, but here it is.

nl.json.txt

seb972 commented 8 years ago

I try and the French language is OK, the Channel is in my language (fr)

pepicora commented 8 years ago

I'm happy to help with an Italian Translation. I'll download the english file asap.

pepicora commented 8 years ago

Here it is the Italian translation, hope it will be ok with the UTF-8 unicode charset :)

it.json.txt

Thanks @ngovil21 for this project!!

ngovil21 commented 8 years ago

@pepicora I have added the Italian translation to the master branch. Thank you for your help!

pepicora commented 8 years ago

@ngovil21 i've found some issues on the italian translation, i'll investigate better and i'll fix it, but can someone help me with the right utf code for this word: "Già" i've used "GiÃ" but don't work.

Also on this line:

"Please enter the name of the TV Show in the search box and press enter.": "Per favore inserisci il nome della Serie TV nel campo di ricerca e premi invio.",

I translated right referring to TV Show but on the channel the popup ask for a Movie

Thanks

ngovil21 commented 8 years ago

@pepicora Should all Gi be Già? I can make that change myself.

You're right about the "Please enter the TV Show" line. I have posted a fix.

pepicora commented 8 years ago

@ngovil21 here are the fixes that are needed under the it.json file for the utf code

già output gi should be già

Già output gi? should be già

é output é should be è

può output pu? should be può

There are something not translated on the channel, here and there, but i can't find it under the en.json file, for example when you report a problem with a file the "missing subtitle" , "bad audio" .... Also when a new user jump in for the first time it tell you "username registered" or something similar in english. Also the channel setup is in english. Is it possible to make a complete localization?

And finally i can't have the channel translated in italian under the android app, i've tryed all i can do but nothing.

Thank you so much for all your work on this channel!

ngovil21 commented 8 years ago

@pepicora I think I have fixed the italian translation errors you pointed out. I didn't see any pu?, all può show up correctly in my editor. Can you verify if its correct in Plex now?

I will add in the rest of the strings at another time, when I get around to it.

For Android, I don't see any way to change the language in the settings. Is the whole Plex app in Italian on Android? The client has to set the language, otherwise nothing I an do with the channel.

Tangoes commented 7 years ago

Hi everybody!

I am translating to SPANISH, but I created es.json file, and nothing changes, the channel is still in English.

Any clue?

ngovil21 commented 7 years ago

@Tangoes Could you attach, your es.json file here if you don't mind sharing? Plex has some bugs with how they handle translations, so I have implemented a work around. I can update the code to include your Spanish translation.

Tangoes commented 7 years ago

Hi @ngovil21 I didn´t translate it all yet. Just translated some strings, and it is not working.

Just copied en.json to en.json. If I translate en.json it works, so it´s a problem related to lang detection.

When I get the translate done, I´ll send it to you.

BR

ngovil21 commented 7 years ago

Ok, to fix this, you will need to add 'es' to the LANGUAGES in init_.py.

If you are familiar with git you can make a fork and send me a pull request once you are done with the translation. Or just attach the es.json file here and I will put it up.

Thank you for your contribution.