search

ngovil21 / RequestChannel.bundle

Request Channel - A Plex Channel to create requests
158 stars 22 forks source link

Update fr.json + Sorting translation files #49

Closed orandin closed 6 years ago

orandin commented 7 years ago
ngovil21 commented 7 years ago

Sorry for getting back to on this. First of all thank you for working on translations and adding a lot of strings. Just a change I would like before I can commit this. I don't like adding multiple strings like L('String 1') + strVar + L("String 2') for localization with variables. These should be handled using the F() method. This is the format method. It works by using %s for variables you want to substitute in and passing the variables in after the string like F("This is a string with 3 variables %s %s %s", strVar1, strVar2, strVar3). This will make the code less cluttered.

If you can't figure it out then just remove the multiple line strings and I will fix it. Thank you for your contribution.

ngovil21 commented 6 years ago

Pull Request now conflicts. I'm going to rewrite some of the default English Strings json to be more updated and manageable in the future. Closing for now. Thank you for your work.