ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.
https://ngoworld.org
MIT License
371 stars 428 forks source link

[FEATURE] Lack of error handling when the category parameter in the URL is not valid #1002

Closed tamannaaaaa closed 1 year ago

tamannaaaaa commented 1 year ago

Description

One potential issue I noticed in the code is the lack of error handling when the category parameter in the URL is not valid. If the category parameter is not one of the predefined values ("art," "decors," or anything else), the component might not display the correct content or could break.

To address this issue, I can add a check to ensure that the category parameter is valid before rendering the component. If the category is not recognized, I can display an error message or redirect the user to a 404 page.

Screenshots

No response

🥦 Browser

Google Chrome

Checklist ✅

github-actions[bot] commented 1 year ago

Hello @tamannaaaaa, thank you for raising the issue.

Currently, the issue is marked as https://github.com/tamalCodes/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

tamalCodes commented 1 year ago

Hi there i am closing this issue as of now.

The whole shops page (mostly frontend) were taken down because of severe issues and lack of proper development. Will be started soon with a new UI that matches our theme in a good way.