ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.
https://ngoworld.org
MIT License
359 stars 419 forks source link

[FEATURE] Merge Authentication for different types of user #1038

Closed tamalCodes closed 1 year ago

tamalCodes commented 1 year ago

Description

So currently we have two different types of user. One of them is the normal user or individual and the other one is basically any kind of club charity or organization.

Now the issue is it consists of a lot of different duplicacies like managing different states, calling separate API's and so on. If you would visit the Club Registration and the User registration, you would notice that a lot of fields are the same like Name , Address, Pincode and so on.

So it would be much better if we can merge these 2 types of authentication into 1 single page. Here's what that are to be done.

Screenshots

image

πŸ₯¦ Browser

Opera

Checklist βœ…

github-actions[bot] commented 1 year ago

Hello @tamalCodes, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource πŸš€

VanshVg commented 1 year ago

Hey @tamalCodes I'd like to work on this issue.

tamalCodes commented 1 year ago

πŸ“š Info

[!NOTE] Branch to make a PR/Fork would be the beta

Hi @VanshVg , you can start working on the issue. Assigning it to you. Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

πŸ“‘ Checklist

Do drop a star, Happy Opensource πŸ’š

VanshVg commented 1 year ago

Hey @tamalCodes I have merged 2 types of authentication in 1 page for Sign Up now. That same modal being open when user clicks on "Sign In" as well so should I remove that modal for Sign In button as well??

tamalCodes commented 1 year ago

Yes, the modal won't open and will take us directly to the auth page. Also do make a PR, it would be better for discussions !

VanshVg commented 1 year ago

Yes, I have opened a PR now you can review it.