[BUG] Incorrect usage of <h1> tag within <footer> element

badrivlog commented 1 year ago

Description

The current components/Footer/Footer.jsx component contains instances where the <h1> tag is being used within the <footer> element. According to HTML5 standards, the <footer> element is typically reserved for footer content and information, while the <h1> tag is used for top-level headings. This structure might not be semantically appropriate and could affect the document's accessibility and readability.

Expected Behavior: The usage of HTML elements should adhere to best practices and semantic guidelines to ensure proper document structure and accessibility.

Actual Behavior: The <h1> tag is being utilized within <footer> elements, potentially causing confusion in terms of heading hierarchy and document structure.

Screenshots

No response

Browser 🥦

Google Chrome

Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (blank for no).

github-actions[bot] commented 1 year ago

Hello @badrivlog, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

madjed-hue commented 1 year ago

hey @badrivlog
can I work on this issue?

tamalCodes commented 1 year ago

📚 Info

[!NOTE] Branch to make a PR/Fork would be the beta

Hi @badrivlog , you can start working on the issue. I see that this is an important one specially coming in terms of a11y. Assigning it to you. Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

📑 Checklist

Setup Guide to understand the setup and the .env(s) for development locally.
Contribution Guide to understand what type of PRs are accepted and how to make them.
Workflow Guide to understand what goes behind the scene, and why your PR doesn't get merged immediately.

Do drop a star, Happy Opensource 💚

ngoworldcommunity / NGOWorld