search

ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.
https://ngoworld.org
MIT License
359 stars 419 forks source link

feat: enable direct access to signup/signin form from respective buttons and merged two types of authetication in one page #1040

Closed VanshVg closed 1 year ago

VanshVg commented 1 year ago

🚧 Fixes Issue

closes #1038

Changes made 👷🏻

Removed the modal which was being opened after clicking Signup/Signin button, Now it directly opens a Form. Added dropdown menu in form which contains two options "Club" and "User" and will show respective fields according to the choice made. Added a validation for password and confirm password meaning those two should be same otherwise it will show error Toast.

Screenshots 📸

image

image

image

Note to Reviewers

Added two new files named "AuthLogin.jsx" and "AuthRegister.jsx" inside /src/pages/Auth. Removed folders named club and user from /src/pages/Auth since it wasn't required anymore.

VanshVg commented 1 year ago

I found one bug in my code so I'm closing this Pull Request and Opening a new one sorry for this inconvenience.

tamalCodes commented 1 year ago

I found one bug in my code so I'm closing this Pull Request and Opening a new one sorry for this inconvenience.

You can simply push the changes here - it would be auto-deployed.

github-actions[bot] commented 1 year ago

This pull request has been deployed to Vercel.

Latest commit: c786447
✅ Preview: https://milan-beta-c9r06m3g6-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan-beta/7KzbD4GW2uMKfbu6YmSFtqZNeZVa

View Workflow Logs