Closed VanshVg closed 1 year ago
github-actions[bot]
commented
1 year ago This pull request has been deployed to Vercel.
| Latest commit: | 247bd8b |
| ✅ Preview: | https://milan-beta-5y27018mj-iamtamal.vercel.app |
| 🔍 Inspect: | https://vercel.com/iamtamal/milan-beta/BE9eaLozjzdmJxwvqoUnD1hsSh5c |
tamalCodes
commented
1 year ago Hi @VanshVg , i think you did the changes in the correct manner. Whenever you will push changes to the branch it will all show up here. Just 2 more things I would like to add.
feat: merging the authentication pages of 2 different types of users you can add short messages too like fix: replaced placeholders with old one and so on. The smaller it is the better it feels to read.
Another thing is clicking on the resolve conversation button whenever you have done and committed those changes. It helps. As you can see outdated means, you have changed this file, so clicking on that resolve conversation button just makes things more professional.
VanshVg
commented
1 year ago Okay, I'll keep these things in mind. Thanx for the help.
🚧 Fixes Issue
closes #1038
Changes made 👷🏻
Removed the modal which was being opened after clicking Signup/Signin button, Now it directly opens a Form. Added dropdown menu in form which contains two options "Club" and "User" and will show respective fields according to the choice made. Added a validation for password and confirm password meaning those two should be same otherwise it will show error Toast.
Screenshots 📸
Note to Reviewers
Added two new files named "AuthLogin.jsx" and "AuthRegister.jsx" inside /src/pages/Auth. Removed folders named club and user from /src/pages/Auth since it wasn't required anymore.