[BUG] No Password validation rules

pamechayash commented 1 year ago

Description

in signing up as a user and as a club, in both forms there is no validation for passwords, the weakest passwords like 11111111 , 12345678 get accepted by it.

Screenshots

No response

Browser 🥦

Google Chrome

Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (blank for no).

github-actions[bot] commented 1 year ago

Hello @pamechayash, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

tamalCodes commented 1 year ago

📚 Info

[!NOTE] Branch to make a PR/Fork would be the beta

1040 might cause small conflicts.

Hi @pamechayash , you can start working on the issue. Assigning it to you. Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans. Since we are focusing on updating Password validation, do update the regex to handle more things.

A digit
A Lowercase character
An Uppercase character
And finally a special character.

That way the strength shall increase.

📑 Checklist

Setup Guide to understand the setup and the .env(s) for development locally.
Contribution Guide to understand what type of PRs are accepted and how to make them.
Workflow Guide to understand what goes behind the scene, and why your PR doesn't get merged immediately.

Do drop a star, Happy Opensource 💚

ngoworldcommunity / NGOWorld