Confirm Password validation is missing [BUG]

ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.

https://ngoworld.org

MIT License

359 stars 418 forks source link

Confirm Password validation is missing [BUG] #1058

Closed khushi89012 closed 1 year ago

khushi89012 commented 1 year ago

Description

Issue if we are writing the password and confirm Password while signup it is getting excepted

Screenshots

No response

Browser 🥦

Google Chrome

Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (blank for no).

github-actions[bot] commented 1 year ago

Hello @khushi89012, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

khushi89012 commented 1 year ago

Please check #1059

tamalCodes commented 1 year ago

Hi there @khushi89012 , please never create any Pull requests until and unless I have assigned you to do so. It's a waste of effort and time. In this case, we have already added such checks in the useValidation hook. It will show up once the user tries to sign up.

https://github.com/MilanCommunity/Milan/blob/a81262b8b0f090d598c0ec6618903dade135d8c3/src/hooks/useValidation.js#L22

and for stronger passwords we are working on #1044 which will resolve this issue. So unfortunately I will have close the PR as well as the issue.