fix: coming soon button not redirecting to signup page

ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.

https://ngoworld.org

MIT License

359 stars 418 forks source link

fix: coming soon button not redirecting to signup page #1066

Closed eliasecasta closed 11 months ago

eliasecasta commented 1 year ago

closes #1065

👷🏻 Changes made

Add the action "signup" to the coming soon button in order to make both pages (events and shop) redirect to the signup page in order to fix the issue.

Note

This is my first-ever open-source contribution so if I missed something please let me know, feedback will be really appreciated :)

github-actions[bot] commented 1 year ago

This pull request has been deployed to Vercel.

Latest commit:	`e8ac752`
✅ Preview:	https://milan-4g4zz80lr-iamtamal.vercel.app
🔍 Inspect:	https://vercel.com/iamtamal/milan/EP4XDMW85EMPy4a37YeRNS8tmPp7

View Workflow Logs

tamalCodes commented 11 months ago

Hi @e71az , great work fixing the issue however there are a couple of things to keep in mind.

Please always ask before making a PR. Why ? For example, in this case, this issue was fixed by me in #1068 and also I have not checked the issue/assigned it to anyone else either.
That is how the time you invested in fixing the bug was wasted. So please always ask.

For now i will be closing this issue and will raise multiple more soon. Keep contributing.