ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.
https://ngoworld.org
MIT License
359 stars 418 forks source link

Feature: Custom modal for CTA #1082

Closed guptaanshik1 closed 10 months ago

guptaanshik1 commented 11 months ago

Description

Whenever someone clicks on the Contact Us CTA in the footer, a blank screen is thrown.

Screenshots

Screenshot 2023-09-25 at 11 46 48 PM

Browser 🥦

Google Chrome

Checklist ✅

github-actions[bot] commented 11 months ago

Hello @guptaanshik1, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

guptaanshik1 commented 11 months ago

I would like to work upon this issue.

tamalCodes commented 11 months ago

Hi @guptaanshik1 , thanks for showing interest in this issue. Previously there was a modal that would pop up when you would click on the button. You can maybe make a reusable modal component that can be used in multiple places. The children can be dynamic, I can render a form within it or maybe something else as per as we need.

Would that be possible ?

guptaanshik1 commented 11 months ago

Hi @tamalCodes yes I would love do that. I just wanted to make sure that can I do this contribution under hacktoberfest23 ? And currently there is a Modal.tsx component. Should I remove it and make reusable modal component?

tamalCodes commented 11 months ago

Sure you can work on this. Hacktoberfest has not started yet, so better hold off those PRs until it starts.

tamalCodes commented 11 months ago

Let's catch up 🙋🏻‍♂️

Hi there, it has been a while since we last had a conversation so I wanted to know if you are still working on this. There might be other issues waiting for this one to be completed.

Please drop a reply shortly so that we know you are active, feel free to convey any problem you face in the comments, or mail me at milanhub.org@gmail.com

guptaanshik1 commented 11 months ago

Let's catch up 🙋🏻‍♂️

Hi there, it has been a while since we last had a conversation so I wanted to know if you are still working on this. There might be other issues waiting for this one to be completed.

Please drop a reply shortly so that we know you are active, feel free to convey any problem you face in the comments, or mail me at milanhub.org@gmail.com

Hi, will be finishing this shortly.

tamalCodes commented 10 months ago

Notice 🚩

Hi there, unfortunately, I will have to close this Issue/PR, as this issue/PR has been inactive for quite a while and there's no work going on for the same.

There might be more Issues/PR that are waiting for this to be completed - so it is better to pace things up. I generally spend/wait for 3 weeks before marking any issue as stale and closing it.

If you think that this is a mistake, please drop an email at milanhub.org@gmail.com, and we will get back to you.

Regards, Team Milan.