🐞Bug: Scroll to top button customization

ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.

https://ngoworld.org

MIT License

359 stars 418 forks source link

🐞Bug: Scroll to top button customization #1088

Closed tamalCodes closed 11 months ago

tamalCodes commented 11 months ago

Description

[!IMPORTANT]
This is a very beginner-friendly issue. Please skip if you have some experience with development and OSS.

The scroll-up button turns transparent when someone hovers over it which is somewhat difficult to spot in places where we might have a dark background. Can you make sure the button is of the same color ?

Screenshots

Browser 🥦

Brave

Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[ ] I am willing to work on this issue (blank for no).

github-actions[bot] commented 11 months ago

Hello @tamalCodes, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

akinpinkman commented 11 months ago

I can work on this issue. Kindly assign it to me.

Shivangbhatnagar237 commented 11 months ago

Hello @tamalCodes, I would like to further discuss on this. The issue that you're referring to is that the button becomes transparent which leads to visibility issues on a dark background. So you want the button to consistently have a white background. Is this correct?

tamalCodes commented 11 months ago

Hi @Shivangbhatnagar237 , there might be a hover property on the button, it would be better if that property were to be removed.

📑 Checklist in case you missed something

Local project setup, .env for the frontend.
Contributing guidelines to be followed.

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

Shivangbhatnagar237 commented 11 months ago

Hey @tamalCodes, I think this hover property is causing the issue

After removing this hover property:

The button doesn't change and maintains the same styles. Is this okay?