Closed Olaleye-Blessing closed 10 months ago
Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.
Give us a ⭐ to show some support Happy OpenSource 🚀
Hi @Olaleye-Blessing , thanks for pointing that out. Can you perhaps explain what more there is to fix this issue ?
From what I can see there is a use of the h1
tag. What do you suggest to fix this issue ?
Ideally, there should be only 1 h1
per page which is the header: Caring Hands, Changing Futures.
. So the h1
I showed in the previous screenshot should probably be h2
.
Also, those clubs are a list of clubs, so ul
> li
is appropriate in this situation.
There should be a main element on the page, a header too.
That sounds good. You can start working on the issue, assigning it to you 🚀
Make sure that the styles are intact across all the devices when the changes are made to the tags.
Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.
Description
The clubs' page lacks some accessibility as shown in the screenshots cause of the wrong use of elements. Using the right elements will greatly improve its accessibility.
Screenshots
🥦 Browser
Brave
Checklist ✅