ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.
https://ngoworld.org
MIT License
355 stars 417 forks source link

feat: changed button hover effect #1139

Closed dhananjay-Byte closed 8 months ago

dhananjay-Byte commented 9 months ago

closes #1134

πŸ‘·πŸ» Changes made

Add a background color to show the differentiation between the buttons which is hovered by the user.

πŸ“Έ Screenshots

Before: ![image](https://github.com/MilanCommunity/Milan/assets/82323909/dec4473b-7e35-45ad-af6d-e30ca187bb40) After: ![image](https://github.com/MilanCommunity/Milan/assets/82323909/cb9dc219-37fc-4a05-ba4d-577d3a0a2242)

Summary by CodeRabbit

tamalCodes commented 8 months ago

Hi @dhananjay-Byte , the changes look good however I would recommend a small change. In cases where there are two buttons side by side, the solid button can have a hover effect (which you applied), and the other button can be as it is (the previous hover effect).

Please make these changes, and ask for a review. I'll merge it soon.

dhananjay-Byte commented 8 months ago

got it

tamalCodes commented 8 months ago

Let's catch up πŸ™‹πŸ»β€β™‚οΈ

Hi there, it has been a while since we last had a conversation so I wanted to know if you are still working on this. Please drop a reply shortly so that we know you are active, feel free to convey any problem you face in the comments, or mail me at milanhub.org@gmail.com

dhananjay-Byte commented 8 months ago

sorry for being inactive @tamalCodes ill patch up this work ASAP from now.

coderabbitai[bot] commented 8 months ago

Walkthrough

The changes in this pull request primarily focus on enhancing the user interface of the Milan Community website. The CSS styles for the ".solid" class in the GlobalButton component have been modified to provide a more distinctive hover effect for buttons, addressing user feedback.

Changes

File Change Summary
.../Button/GlobalButton/Button.module.css The color and background color of the ".solid" class have been changed. A transition property has been added to create a hover effect.

Assessment against linked issues (Beta)

Objective Addressed Explanation
Enhance the hover effect of buttons (#1134) βœ… The changes in the CSS styles for the ".solid" class in the GlobalButton component create a more distinctive hover effect.
Use the heading color for the hover effect (#1134) ❓ The background color has been changed to #28183B, but it's unclear if this is the heading color mentioned in the issue.
Improve user understanding that the button will navigate to another page (#1134) ❌ The changes made only affect the visual aspect of the button. There's no clear indication that the button will navigate to another page.

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai help` to get help. - `@coderabbitai resolve` to resolve all the CodeRabbit review comments. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
github-actions[bot] commented 8 months ago

This pull request has been deployed to Vercel.

Latest commit: d5bfb6d
βœ… Preview: https://milan-deoa1ue4b-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/EwbMGSubgR7rXxLS5QreZ1w8kXap

View Workflow Logs