Closed dhananjay-Byte closed 8 months ago
Hi @dhananjay-Byte , the changes look good however I would recommend a small change. In cases where there are two buttons side by side, the solid button can have a hover effect (which you applied), and the other button can be as it is (the previous hover effect).
Please make these changes, and ask for a review. I'll merge it soon.
got it
Hi there, it has been a while since we last had a conversation so I wanted to know if you are still working on this. Please drop a reply shortly so that we know you are active, feel free to convey any problem you face in the comments, or mail me at milanhub.org@gmail.com
sorry for being inactive @tamalCodes ill patch up this work ASAP from now.
The changes in this pull request primarily focus on enhancing the user interface of the Milan Community website. The CSS styles for the ".solid" class in the GlobalButton component have been modified to provide a more distinctive hover effect for buttons, addressing user feedback.
File | Change Summary |
---|---|
.../Button/GlobalButton/Button.module.css |
The color and background color of the ".solid" class have been changed. A transition property has been added to create a hover effect. |
Objective | Addressed | Explanation |
---|---|---|
Enhance the hover effect of buttons (#1134) | β | The changes in the CSS styles for the ".solid" class in the GlobalButton component create a more distinctive hover effect. |
Use the heading color for the hover effect (#1134) | β | The background color has been changed to #28183B, but it's unclear if this is the heading color mentioned in the issue. |
Improve user understanding that the button will navigate to another page (#1134) | β | The changes made only affect the visual aspect of the button. There's no clear indication that the button will navigate to another page. |
This pull request has been deployed to Vercel.
Latest commit: | d5bfb6d |
β Preview: | https://milan-deoa1ue4b-iamtamal.vercel.app |
π Inspect: | https://vercel.com/iamtamal/milan/EwbMGSubgR7rXxLS5QreZ1w8kXap |
closes #1134
π·π» Changes made
Add a background color to show the differentiation between the buttons which is hovered by the user.
πΈ Screenshots
Before: ![image](https://github.com/MilanCommunity/Milan/assets/82323909/dec4473b-7e35-45ad-af6d-e30ca187bb40) After: ![image](https://github.com/MilanCommunity/Milan/assets/82323909/cb9dc219-37fc-4a05-ba4d-577d3a0a2242)Summary by CodeRabbit