Closed nishitxmehta closed 6 months ago
Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.
Give us a ⭐ to show some support Happy OpenSource 🚀
Hi maintainers, I'm willing to submit a PR for this issue. If you consider this, please assign me this issue.
@tamalCodes I would love to work on this issue!
@tamalCodes @nishitxmehta I would love to work on this issue as well
Hi @tamalCodes, if you consider this issue please assign this to me.
Hi @nishitxmehta , for the time being, we do not have any dark mode either. So would you be willing to add dark mode to the whole webapp along with the button ?
Hi @tamalCodes, definitely I'll add dark mode to the whole webapp along with the button.
You can go through my portfolio, their I've added a theme change button.
@nishitxmehta would you mind collaborating on this? I would love to help
Hi there yes please do add it @nishitxmehta , also feel free to collaborate with @T1LT ! Assigning this to both of you.
Hi @tamalCodes, thanks for assigning to both of us. @T1LT, I'll reach out to you soon.
@nishitxmehta @tamalCodes I would love to work on this issue as well
Hi @tamalCodes, can you please unassign me the issue and assign others as right now due to some urgency I'm unable to work on the issue. I apologise for this. Therefore, please assign other interested candidates for this issue. I will definitely contribute to this repository later on. 😄
Sure @nishitxmehta Also @swapnilbhakare , you can start to work on it too !
@swapnilbhakare I will reach out to you on linkedin soon
Dear MilanCommunity/Milan,
Acknowledged.
Thanks & regards Swapnil bhakare
On Sat, Nov 4, 2023, 20:43 Tamal Das @.***> wrote:
Assigned #1147 https://github.com/MilanCommunity/Milan/issues/1147 to @swapnilbhakare https://github.com/swapnilbhakare.
— Reply to this email directly, view it on GitHub https://github.com/MilanCommunity/Milan/issues/1147#event-10863036021, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQEAX65CVWVGDFNWAUZBBZTYCZLRTAVCNFSM6AAAAAA6KZIZOWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHA3DGMBTGYYDEMI . You are receiving this because you were assigned.Message ID: @.***>
Hi there, it has been a while since we last had a conversation so I wanted to know if you are still working on this. Please drop a reply shortly so that we know you are active, feel free to convey any problem you face in the comments, or mail me at milanhub.org@gmail.com
@tamalCodes still active, was curious if you would be okay with making a bunch of changes to a couple of CSS files as we don't have global variables for colors set up.
Description
There's no Theme Change button i.e. the
light/dark mode
button.Proposed Solution
The solution is to add a Theme Change button in the
Navigation Bar
of the website.Screenshots
For Large Devices
For Small Devices
🥦 Browser
Brave
Checklist ✅