ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.
https://ngoworld.org
MIT License
355 stars 417 forks source link

Bug: Toggle Password Visibility Not Working. #1156

Closed rasel9t6 closed 6 months ago

rasel9t6 commented 8 months ago

Description

Toggle password visibility not working on the Sign up and Log in / Sign in page. As a result, users will not be able to understand or review whether their provided password and Confirm password is incorrect or correct / match or mismatch.

Proposed Solution

This might be a solution from W3 Schools Documentation. Bellow the Link W3 School Doc

Screenshots

Screenshot 2023-10-28 231616 Screenshot 2023-10-28 233258

Browser 🥦

Mozilla Firefox

Checklist ✅

github-actions[bot] commented 8 months ago

Hello @rasel9t6, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

P-Jaswanth commented 8 months ago

Hey, I would like to work on this. Could you please assign this to me.

Aryashakya commented 8 months ago

I have tried it and it is working for me. image image

rasel9t6 commented 8 months ago

I have tried it and it is working for me. image image It's not working for me.

tamalCodes commented 8 months ago

Hey @rasel9t6 , it is working fine for me (Chrome, Brave). I'm not sure if there's gonna be a problem in Mozilla, can you try clearing out all the cache and try once again ?

MangeshGawas commented 7 months ago

Hey, @rasel9t6 Its an bug in mozilla firefox browser , I Fixed that bug.[

https://github.com/MilanCommunity/Milan/assets/70948059/01e58cd0-4f0e-428a-92a8-1b338216f15c

](url)

tamalCodes commented 7 months ago

Hi @MangeshGawas, would be great if you can make a PR 🚀

📑 Checklist in case you missed something

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

MangeshGawas commented 7 months ago

code committed

tamalCodes commented 7 months ago

Do raise a PR, and remove the package-lock.json file from the changes too. Make sure you read our docs on how to make a proper PR !

github-actions[bot] commented 4 months ago

Hi @tamalCodes, We just made a new organization, and have sent you an invite. Welcome to the community 🎉

Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/MilanCommunity/people