Other: Sign in Sign up buttons in Navbar

ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.

https://ngoworld.org

MIT License

352 stars 413 forks source link

Other: Sign in Sign up buttons in Navbar #1166

Closed Saekit closed 5 months ago

Saekit commented 8 months ago

What would you like to share?

I would like to propose some style changes to the Sign in/Sign up buttons in the navbar.

Change "Sign in" to "Log in" for better UI/UX experience, also to match the footer
Change the style of the Log in button to only have an underline (on hover), so it differentiates from the Sign up button
Align all nav items

Issues:

Funny looking button behavior:

https://github.com/MilanCommunity/Milan/assets/42038008/6ced48af-4d12-4ce3-9015-5328961447aa

Misalignment:

Solution:

🥦 Browser

Google Chrome

Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[ ] I am willing to work on this issue (blank for no)

github-actions[bot] commented 8 months ago

Hello @Saekit, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

tamalCodes commented 8 months ago

Sounds good to me however, I would also like to suggest some changes.

The buttons can be changed, instead of having two, we can have one.
We just keep a main button, which says Sign In or something like that (check the screenshot below)
Also the line height probably is probably causing some issues with the misalignment.

Saekit commented 8 months ago

@tamalCodes Just to clarify, are you suggesting completely removing the Sign up button from the navbar and only having a log in button that keeps the current style?

deveshtanwar-IMG commented 8 months ago

sir can you please assign this issue to me ?

tamalCodes commented 7 months ago

@tamalCodes Just to clarify, are you suggesting completely removing the Sign up button from the navbar and only having a log in button that keeps the current style?

Yes

Bilal7659 commented 7 months ago

can i work on it as it available i know it

Saikat-Mandal commented 7 months ago

Hi there @tamalCodes i went through the conversation above. I guess i can the fix this issue.

prajwalbandak commented 6 months ago

Hey @tamalCodes, I've made the changes locally. Could you please assign the issue to me? It will be helpful for me to create a pull request.

dev0869 commented 6 months ago

Hey I would love to work on this issue.