Bug: Validation error in signup form

ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.

https://ngoworld.org

MIT License

366 stars 422 forks source link

Bug: Validation error in signup form #1172

Closed deepakk33 closed 10 months ago

deepakk33 commented 11 months ago

Description

Validation error should come inside form only rather than in form Toast massage , it will help user to catch error easily.

Proposed Solution

rather than using toast make object for every feild-state that can contains validation error as well so we can show error just below of the fields.

Screenshots

No response

Browser 🥦

Google Chrome

Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[ ] I am willing to work on this issue (blank for no).

github-actions[bot] commented 11 months ago

Hello @deepakk33, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

Bashamega commented 10 months ago

Hello:) I am interested in solving this issue. Can you assign me?

tamalCodes commented 10 months ago

Hi @Bashamega , you can go forward with the issue.

📑 Checklist in case you missed something

Local project setup, .env for the frontend.
Contributing guidelines to be followed.

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

Bashamega commented 10 months ago

Hi @Bashamega , you can go forward with the issue.

📑 Checklist in case you missed something

Local project setup, .env for the frontend.

Contributing guidelines to be followed.

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

Thank you very much, but I am busy contributing to other projects. Sorry so much

Endless8 commented 10 months ago

Hey, I am willing to work on this issue

github-actions[bot] commented 6 months ago

Hi @tamalCodes, We just made a new organization, and have sent you an invite. Welcome to the community 🎉

Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/MilanCommunity/people