ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.
https://ngoworld.org
MIT License
352 stars 413 forks source link

Bug Report: Password Hide Option Not Functioning in Sign In #1192

Closed NaveenChandraAdhikari closed 5 months ago

NaveenChandraAdhikari commented 5 months ago

Description

This bug report addresses an issue where the "hide password" functionality is not working as intended. Users are unable to hide the password, which impacts the user experience negatively. This bug needs to be resolved promptly to ensure the proper functioning of the password hide option. this issue creates problem not in sign in but also in Sign up Page TOO

Assigm me this under JWOC'24

Proposed Solution

debugging and fixing the js and HTMl markup fix the issue

Screenshots

Screenshot from 2024-01-11 02-12-54

Browser 🥦

Google Chrome

Checklist ✅

github-actions[bot] commented 5 months ago

Hello @NaveenChandraAdhikari, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

Himanxu1 commented 5 months ago

It's working perfectly fine @NaveenChandraAdhikari

tamalCodes commented 5 months ago

Same here, works fine for me too.

@NaveenChandraAdhikari , mind sharing a screen recording ?

NaveenChandraAdhikari commented 5 months ago

Apology: Issue Only Occurs on My Machine @tamalCodes but can I add Add Typewriter Effect to banner_header1 and Underlined Text effect while hover in Footer auth_text for better UI

tamalCodes commented 5 months ago

Typewriter effects are generally considered bad UI both in terms of accessibility and SEO. I'll let that pass for now, i will be closing this issue.