ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.
https://ngoworld.org
MIT License
352 stars 413 forks source link

Feature: Frontend Form validation required in Sign/Sign Up #1194

Closed Himanxu1 closed 5 months ago

Himanxu1 commented 5 months ago

Description

Validation is crucial when it comes to form , Sign In and Sign Up pages should have validations

Proposed Solution

We can use Yup/Formik to make it work .

Screenshots

No response

🥦 Browser

Google Chrome

Checklist ✅

github-actions[bot] commented 5 months ago

Hello @Himanxu1, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

shashank20-02 commented 5 months ago

Please assign this task to me. I would love to work on this.

tamalCodes commented 5 months ago

Hi there, you have not checked out the code or the auth pages. We have custom hooks that take care of these. Would using a third-party library complicate this or ease this ?

image

vinaybhamre commented 5 months ago

we can use zod + react-hook-form to implement the form

tamalCodes commented 5 months ago

we can use zod + react-hook-form to implement the form

Currently, we are using the useValidation hook for this simple form. I think we will be using zod + react-hook-form soon when we set up how to generate events, funding, and more detailed and complicated stuff like that !

For now I will be closing the issue as for a form of this scale - we won't need extra codes.