search

ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.
https://ngoworld.org
MIT License
352 stars 413 forks source link

feat: revamping the Navbar #1195 #1199

Closed pranay911 closed 5 months ago

pranay911 commented 5 months ago

Changed the color of the navigation item and Added a navigation button according to design.

📸 Screenshots

![image](https://github.com/milancommunity/Milan/assets/65008142/873e0e21-b8e7-4def-938e-93f204ac91f2)
tamalCodes commented 5 months ago

Hi @pranay911 this looks amazing however the navbar looks quite off-center. This is a design issue I guess, can anything be done so that we make the navbar more centred ?

For example, take a look at image

pranay911 commented 5 months ago

Hi @tamalCodes I've considered all the approaches you mentioned. In the provided image, there's only one item on the right side. However, on your website, two buttons – "Contribute to Milan" and "Sign Up" – occupy some space. Due to this, the navigation items are not centered as expected.

pranay911 commented 5 months ago

Hey @tamalCodes, good evening! Following our discussion, I've made the following changes:

  1. Added a new class for rounded buttons.
  2. Corrected the border-radius.
pranay911 commented 5 months ago

Hey @tamalCodes, any updates on PR?

pranay911 commented 5 months ago

Now its looks Pretty

image

github-actions[bot] commented 5 months ago

This pull request has been deployed to Vercel.

Latest commit: 084ab91
✅ Preview: https://milan-beta-mr81nrns6-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan-beta/CLEXGsatzGCNGoABqKNrSWFcEyLQ

View Workflow Logs