Closed Pranathi2011 closed 4 months ago
This pull request has been deployed to Vercel.
Latest commit: | c3bfa91 |
β Preview: | https://milan-eerg69347-iamtamal.vercel.app |
π Inspect: | https://vercel.com/iamtamal/milan/3UUPsCv6NxDcmcfD7xMDoV65K7U4 |
@tamalCodes any comments on this pr ?
Hi @Pranathi2011 , please fix the conflicts and push the changes.
The dark mode that you have implemented looks out of place - so it's better to add a dark mode rather than purple. Checkout other dark modes that you can find in projects. Same goes for the footer as well - it looks like light themed even if the whole theme is dark
Hi there, unfortunately, I will have to close this Issue/PR, as this issue/PR has been inactive for quite a while and there's no work going on for the same.
There might be more Issues/PR that are waiting for this to be completed - so it is better to pace things up. I generally spend/wait for 3 weeks before marking any issue as stale and closing it.
If you think that this is a mistake, please drop an email at milanhub.org@gmail.com, and we will get back to you.
Regards, Team Milan.
closes #
π·π» Changes made
Introduced a button to toggle between dark mode and light mode, changed appropriate css properties to match the dark theme.
πΈ Screenshots
![image](https://github.com/milancommunity/Milan/assets/96493900/32fda4b4-65e8-40d4-89cc-836116c10a0b) ![image](https://github.com/milancommunity/Milan/assets/96493900/cd6f31bd-fffc-43e6-a104-0b4ae006e0c8) ![image](https://github.com/milancommunity/Milan/assets/96493900/4b6df8e2-77e8-45e3-bbde-de69b19740d3)