ngoworldcommunity / NGOWorld

A platform to connect and support NGOs, charities and you to build a better tomorrow.
https://ngoworld.org
MIT License
373 stars 427 forks source link

Bug: Signup Button Loader Runs Without Email and Password Input #1258

Closed st17931 closed 4 weeks ago

st17931 commented 2 months ago

Description

The loader on the Signup button is triggered even when there are no values entered in the email and password fields. This behavior is unexpected, as the loader should only activate when the user has entered valid data and submitted the form.

Steps to Reproduce:

  1. Navigate to the Signup page.
  2. Leave the email and password fields empty.
  3. Click on the Signup button.

Expected Behavior: The Signup button should only show the loader when valid inputs are provided and the form is submitted.

Actual Behavior: The loader is activated immediately upon clicking the Signup button, regardless of whether the email and password fields are filled.

Impact: This bug may confuse users as it suggests that the signup process has started when it has not.

Proposed Solution

To resolve this issue, we will implement the following changes:

Remove Loader on Empty Fields: We will modify the logic to ensure that the loader does not run when the email and password fields are empty. This will prevent unnecessary loading indicators when the form is incomplete.

Trigger Loader on Valid Input: The loader will be activated only when both the email and password fields have valid input and the user submits the form. This ensures that the loading state reflects the actual processing of the signup request.

Form Validation: Before triggering the loader, the form will be validated to check if the required fields (email and password) are filled. If validation passes, the loader will be triggered; otherwise, an appropriate error message will be displayed without initiating the loader.

Screenshots

Signup_page_issue.webm Signup_loader_issue

Browser 🥦

Google Chrome

Checklist ✅

github-actions[bot] commented 2 months ago

Hello @st17931, thank you for raising the issue.

Currently, the issue is marked as https://github.com/ngoworldcommunity/NGOWorld/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

Nirpendra09 commented 2 months ago

Hi @tamalCodes can you assign this to me?

shreya-mangade commented 1 month ago

Hello @tamalCodes , Can you please assign this issue to me?

r0ld3x commented 1 month ago

@tamalCodes hey can you assign me?