search

ngraziano / SharpRTSP

A RTSP handling library
Other
557 stars 182 forks source link

fix parsing of fmtp config in cases where sampling freq is specified directly #90

Closed bentorkington closed 1 year ago

bentorkington commented 1 year ago

ISO 14496-1 1.6.2.1 allows for the sampling frequency to be directly specified as a 24 bit integer. Without this fix, the ChannelConfiguration would be incorrectly read in these cases.

I'm not sure how you might want to rework the Received_AAC_Delegate since it currently passes only the index, so I've left this alone just to ensure that at least the ChannelConfiguration will remain correct.

ngraziano commented 1 year ago

I have merged it. IPayloadProcessor need some work but I don't have a lot of time, maybe one day I will improve this code.

bentorkington commented 1 year ago

I'm doing some work with the sample RTSPClient to add Opus support to it. I'll take a look and see if any useful refactoring can be done with the payload processor and submit PRs