ngrok / kubernetes-ingress-controller

The official ngrok Ingress Controller for Kubernetes
https://ngrok.com
MIT License
184 stars 20 forks source link

fix: Remove unnecessary break in sync create/update loops #270

Closed jonstacks closed 1 year ago

jonstacks commented 1 year ago

What

These break statements shouldn't be here. They are breaking the out of the outer loop and are likely causing some of the desired domains, tunnels, edges not being created as fast as they could be. Luckily, they'll be caught in the next sync loop since they will exist and follow the update flow and the inner for loop will be broken, moving onto the next one

How

Remove the unnecessary break statements which cause reconciliation to take longer

Breaking Changes

No