Closed pmalek closed 10 months ago
Thank you for the report @pmalek ! Currently, the controller is watching NgrokModuleSet
CRs for changes, but it is not triggering reconciliation. We’ll be looking into addressing this gotcha next, but for the time being, operators either need to restart the controller or change some of the ingress objects to trigger reconciliation. One neat way you could do this is to create and set a new NgrokModuleSet
CR for your ingress, instead of updating the old CR.
Also, we are happy to look over a PR if you wanna explore the fix yourself.
Thanks for response. I'll wait until you provide the fix as it's not obvious to me where and how to change (ingress controller https://github.com/ngrok/kubernetes-ingress-controller/blob/main/internal/controllers/ingress_controller.go I suppose) the code to make it work.
What happened
After applying
NgrokModuleSet
with e.g. oauth set to google email address and changing the email address there's no change in the managedEdge
.What you think should happen instead
After applying
NgrokModuleSet
with e.g. oauth set to google email address and changing the email address, managedEdge
should be changedHow to reproduce
Apply (e.g. via
kubectl apply ...
) below listed manifest (substitute domain and email address with your own)Verify that you can access
<DOMAIN>
using<EMAIL>
address via google authentication.Change
<EMAIL>
to<EMAIL2>
and apply the changes (e.g.kubectl apply ...
)Verify that you can still access
<DOMAIN>
using<EMAIL>
address via google authentication and not via<EMAIL2>