ngrok / kubernetes-ingress-controller

The official ngrok Ingress Controller for Kubernetes
https://ngrok.com
MIT License
184 stars 20 forks source link

Reconciling ngrok-module-set changes #290

Closed nikolay-ngrok closed 10 months ago

nikolay-ngrok commented 11 months ago

closes: #287

What

Currently, the controller watches for changes in NgrokModuleSet CRs (and persists the updates), but it is not actively triggering reconciliation when they change. This means that changes only in modules are not applied to the HTTPSEdge CRs when the NgrokModuleSet CRs referenced by an Ingress get changed.

Once this PR merges, both Ingress and NgrokModuleSet will trigger reconciliation and will keep dependent objects up to date.

How

Breaking Changes

None

nikolay-ngrok commented 10 months ago

@jrobsonchase this is ready for rereview, the CI is broken from a previous merge (which I'll look at merging before this)