Currently, the controller watches for changes in NgrokModuleSet CRs (and persists the updates), but it is not actively triggering reconciliation when they change. This means that changes only in modules are not applied to the HTTPSEdge CRs when the NgrokModuleSet CRs referenced by an Ingress get changed.
Once this PR merges, both Ingress and NgrokModuleSet will trigger reconciliation and will keep dependent objects up to date.
How
Add another controller that owns and watches NgrokModuleSets
Trigger partial reconciliation, since only HTTPSEdges are affected by modules
Make sure we are not doing too many changes, since both Sync methods might run concurrently
closes: #287
What
Currently, the controller watches for changes in
NgrokModuleSet
CRs (and persists the updates), but it is not actively triggering reconciliation when they change. This means that changes only in modules are not applied to theHTTPSEdge
CRs when theNgrokModuleSet
CRs referenced by anIngress
get changed.Once this PR merges, both
Ingress
andNgrokModuleSet
will trigger reconciliation and will keep dependent objects up to date.How
NgrokModuleSet
sHTTPSEdges
are affected by modulesSync
methods might run concurrentlyBreaking Changes
None