ngrok / kubernetes-ingress-controller

The official ngrok Ingress Controller for Kubernetes
https://ngrok.com
MIT License
183 stars 20 forks source link

do no check env in CI #297

Closed nikolay-ngrok closed 10 months ago

nikolay-ngrok commented 10 months ago

What

We introduced a change that requires NGROK_AUTHTOKEN and NGROK_API_KEY vars to be set on deploy, which is useful when doing manual deploys. However, in CI we use the same, but just to see if we can deploy successfully, without actually using the values for these vars. In this case, the ci build fails, since it checks these vars as part of the make deploy run.

How

Split deploy cmd/script to two parts, and use the one that doesn't check in CI.

Breaking Changes

None