search

ngrok / kubernetes-ingress-controller

The official ngrok Ingress Controller for Kubernetes
https://ngrok.com
MIT License
183 stars 20 forks source link

Support container lifecycle hooks #299

Closed basilnsage closed 9 months ago

basilnsage commented 10 months ago

Description

Hello,

Please expose a config option to allow users to customize the ingress controller container's lifecycle hooks. Happy to raise a PR if this request sounds reasonable.

Thanks,

Use Case

I have custom cleanup actions that I need to perform before stopping the controller container. Currently, the Helm chart doesn't support methods to trigger these custom actions, and I'd prefer not to go through the effort of creating a mutating webhook just for this.

Related issues

No response

nikolay-ngrok commented 10 months ago

Hello @basilnsage,

We're happy to look over a PR that covers your thinking/needs.

Meanwhile, I'll be looking at the documentation and experiment to confirm if we want to support this for the ingress controller. From the documentation, it seems like you might need exec style of lifecycle hook, is this correct?