search

ngrok / kubernetes-ingress-controller

The official ngrok Ingress Controller for Kubernetes
https://ngrok.com
MIT License
183 stars 20 forks source link

appProtocol support for http2 #323

Closed nikolay-ngrok closed 7 months ago

nikolay-ngrok commented 7 months ago

What

We are adding http2 support, expose this in the controller.

How

Resolve and pass around to tunnel CRD.

Breaking Changes

None. We should merge only after we update to ngrok-go stable.

jrobsonchase commented 7 months ago

Welp, I tried to help you out with https://github.com/ngrok/kubernetes-ingress-controller/pull/324, but since we can't use tls.Config.InsecureSkipVerify via the forwarding api, you'll have to continue duplicating a bit of logic :cry:

If http2 is configured as the appProtocol and we're also terminating TLS against the upstream/backend, you'll also need to set tls.Config.NextProto to []string{"h2", "http/1.1"} so that the service knows what to expect.