search

ngrok / kubernetes-ingress-controller

The official ngrok Ingress Controller for Kubernetes
https://ngrok.com
MIT License
183 stars 20 forks source link

tunneldriver: use the ngrok-go provided forwarding mechanism #324

Open jrobsonchase opened 7 months ago

jrobsonchase commented 7 months ago

What

Use the upstream ListenAndForward API instead of reimplementing the connection join logic.

This also lets us lean on the upstream TLS terminating semantics and (soon) its HTTP/2 interaction with TLS.

How

Remove handleConns and handleConn in favor of the ngrok-go provided API.

Breaking Changes

None

jrobsonchase commented 7 months ago

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

jrobsonchase commented 7 months ago

Ugh, I forgot that we haven't added the options for making the forwarding TLS config use InsecureSkipVerify :cry:

Back to draft it goes.

CK-Ward commented 1 month ago

@jrobsonchase what are the next steps on this ticket?