helm: add apiURL option - Githubissues

ngrok / kubernetes-ingress-controller

The official ngrok Ingress Controller for Kubernetes

https://ngrok.com

MIT License

183 stars 20 forks source link

helm: add apiURL option #362

Closed jrobsonchase closed 2 months ago

jrobsonchase commented 2 months ago

What

Adds a helm value to set the API URL as an alternative to the NGROK_API_URL environment variable.

How

Boring helm plumbing
Keep the default from the environment, but override it if the helm value is set

Breaking Changes

None, since no one should have this helm value set. Existing users can continue with the env var and switch to the helm value at their leisure.

github-actions[bot] commented 2 months ago

:wave: Looks like there are changes in the Helm Chart's Chart.yaml file. Upon merge, a new release of the helm chart will be created if the Chart's version was changed.

github-actions[bot] commented 2 months ago

:wave: Looks like there are changes in the VERSION file. Upon merge, a new release of the docker image will be created. Please make sure the version is updated appropriately.

github-actions[bot] commented 2 months ago

:wave: Looks like there are changes in the Helm Chart's Chart.yaml file. Upon merge, a new release of the helm chart will be created if the Chart's version was changed.

github-actions[bot] commented 2 months ago

:wave: Looks like there are changes in the VERSION file. Upon merge, a new release of the docker image will be created. Please make sure the version is updated appropriately.

github-actions[bot] commented 2 months ago

:wave: Looks like there are changes in the Helm Chart's Chart.yaml file. Upon merge, a new release of the helm chart will be created if the Chart's version was changed.

github-actions[bot] commented 2 months ago

:wave: Looks like there are changes in the VERSION file. Upon merge, a new release of the docker image will be created. Please make sure the version is updated appropriately.

github-actions[bot] commented 2 months ago

:wave: Looks like there are changes in the Helm Chart's Chart.yaml file. Upon merge, a new release of the helm chart will be created if the Chart's version was changed.

github-actions[bot] commented 2 months ago

:wave: Looks like there are changes in the VERSION file. Upon merge, a new release of the docker image will be created. Please make sure the version is updated appropriately.

github-actions[bot] commented 2 months ago

:wave: Looks like there are changes in the Helm Chart's Chart.yaml file. Upon merge, a new release of the helm chart will be created if the Chart's version was changed.

github-actions[bot] commented 2 months ago

:wave: Looks like there are changes in the VERSION file. Upon merge, a new release of the docker image will be created. Please make sure the version is updated appropriately.