ngrok / kubernetes-ingress-controller

The official ngrok Ingress Controller for Kubernetes
https://ngrok.com
MIT License
183 stars 20 forks source link

Handle non-existent backend IDs more gracefully #380

Closed jonstacks closed 1 month ago

jonstacks commented 1 month ago

What

Defensive coding in case the Tunnel Group Backend referenced by an edge does not actually exist. It is a pretty rare case, but if you hit it, you'll end up in a forever loop of not being able to create a new TCP/TLS Edge which isn't great.

How

If we get a 404 / ngrok.IsNotFound(err) == true when getting the backend referenced by the edge by ID, we can't hope to match on this edge and it is not a potential candidate for adoption, so just skip over it and continue the search.

Breaking Changes

No