ngrok / kubernetes-ingress-controller

The official ngrok Ingress Controller for Kubernetes
https://ngrok.com
MIT License
183 stars 20 forks source link

refactor: annotations parsers to handle client.Object instead of just networking.Ingress #384

Closed jonstacks closed 1 month ago

jonstacks commented 1 month ago

What

The annotations parser currently expects an ingress of type *networking.Ingress. We can make this more flexible for our use case and allow it to parse annotations from any client.Object. We'll want this shortly for being able to extract annotations from services for example in #375

How

*networking.Ingress implements client.Object so all of our changes are just in the internal/annotations package.

Breaking Changes

No