search

ngrok / ngrok-java

Embed ngrok secure ingress into your Java apps with a single line of code.
Other
21 stars 6 forks source link

Java 11 compatible compilation #4

Closed markrekveld closed 11 months ago

markrekveld commented 1 year ago

My attempt at #1

CarlAmko commented 12 months ago

Thanks for the PR @markrekveld.

We have an internal effort on the roadmap to determine which JDK versions we can support and how to best facilitate them to end users. Stay posted!

markrekveld commented 12 months ago

@Wonderful-Space good news, but do you have any time window in which the decision will be made.

CarlAmko commented 11 months ago

Hi @markrekveld, I’m investigating support for JDK 11, but I’m seeing some breaking changes since we are using newer language constructs and API features from Java 17. We’ll get back to you on a timeline tomorrow.

nijikokun commented 11 months ago

@Wonderful-Space good news, but do you have any time window in which the decision will be made.

Hey Mark, thanks for the PR!

I'm going to go ahead and close this PR since it looks like work is happening over in #12.

Feel free to check it out and follow along / give input!

nijikokun commented 11 months ago

Just following up on this thread @markrekveld looks like #12 has landed and now Java 11 is supported 🎉

markrekveld commented 11 months ago

Thanks @nijikokun and ngrok team!