feat: add app protocol - Githubissues

ngrok / ngrok-rust

Embed ngrok secure ingress into your Rust apps with a single line of code.

Apache License 2.0

319 stars 19 forks source link

feat: add app protocol #130

Closed OfTheDelmer closed 9 months ago

OfTheDelmer commented 10 months ago

Why

We'd like to be able specify http2 when building an http tunnel

How

Add app_protocol to the builder and plumb the forwards_proto into the session rpc.

Validation

Run an example with the http2 app protocol and confirm the correct forwardsProto was set to "http2" or "" .

jrobsonchase commented 10 months ago

Current dependencies on/for this PR:

main
- PR #130 👈
- PR #131

This stack of pull requests is managed by Graphite.

salilsub commented 10 months ago

I think as a general rule we should push more validation to our hosted services so we can adjust those rules over time. There will be exceptions, but I think @jrobsonchase is right on this one.