ngrok: set the alpn field when app_protocol is specified

ngrok / ngrok-rust

Embed ngrok secure ingress into your Rust apps with a single line of code.

Apache License 2.0

310 stars 18 forks source link

ngrok: set the alpn field when app_protocol is specified #131

Closed jrobsonchase closed 8 months ago

jrobsonchase commented 9 months ago

If the upstream is a normal HTTPs server, it expects to have http/2 negotiated via alpn. If alpn isn't provided, it will assume http/1.1. If our edge proxy is sending down http/2 because app_protocol was specified, this results in a protocol mismatch, and invalid requests/responses will be seen.

This ensures that the negotiation happens as expected.

jrobsonchase commented 9 months ago

Current dependencies on/for this PR:

main
- PR #130
- PR #131 👈

This stack of pull requests is managed by Graphite.