ngrok / ngrok-rust

Embed ngrok secure ingress into your Rust apps with a single line of code.
Apache License 2.0
310 stars 18 forks source link

update hyper and axum #137

Open jrobsonchase opened 7 months ago

jrobsonchase commented 7 months ago

Significant breakage, since hyper 1.0 introduced significant breakage.

Of note:

All in all, not super happy about this change. Hyper used to provide a nice pluggable interface where you could bring-your-own listener type, and that's been entirely done away with. Axum didn't fill in the gap very well, and their serve function explicitly takes a TCP listener. Not sure we want to provide yet another accept-serve loop.

Since hyper is 1.0 and stable though, I feel better about providing implementations of the traits that they do offer. Maybe the rest of the ecosystem will catch up and figure out how to not depend on TcpListener directly.

Resolves #126 Resolves #136

Abdiramen commented 7 months ago

All in all, not super happy about this change. Hyper used to provide a nice pluggable interface where you could bring-your-own listener type, and that's been entirely done away with.

Hopefully, as hyper-utils matures they develop a new pluggable interface.

zaijie1213 commented 1 week ago

When is this PR expected to be integrated?