Open jrobsonchase opened 7 months ago
All in all, not super happy about this change. Hyper used to provide a nice pluggable interface where you could bring-your-own listener type, and that's been entirely done away with.
Hopefully, as hyper-utils
matures they develop a new pluggable interface.
When is this PR expected to be integrated?
Significant breakage, since hyper 1.0 introduced significant breakage.
Of note:
Accept
trait, and no more hyper-provided server. Examples are all modeled after the axum serve-with-hyper example.Conn
now implements the hyper read/write traits, because why not?All in all, not super happy about this change. Hyper used to provide a nice pluggable interface where you could bring-your-own listener type, and that's been entirely done away with. Axum didn't fill in the gap very well, and their
serve
function explicitly takes a TCP listener. Not sure we want to provide yet another accept-serve loop.Since hyper is 1.0 and stable though, I feel better about providing implementations of the traits that they do offer. Maybe the rest of the ecosystem will catch up and figure out how to not depend on
TcpListener
directly.Resolves #126 Resolves #136